From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 4/6] arm, da850evm: Add an SPL for SPI boot
Date: Mon, 5 Dec 2011 08:19:10 -0700 [thread overview]
Message-ID: <4EDCE0EE.70702@ti.com> (raw)
In-Reply-To: <1323082732-32682-5-git-send-email-christian.riesch@omicron.at>
On 12/05/2011 03:58 AM, Christian Riesch wrote:
[snip]
> include/configs/da850evm.h | 87 +++++++++++++++++++++++++++++++++
[snip]
> +#define CONFIG_SYS_DA850_DDR2_SDTIMR2 ( \
> + (7 << DV_DDR_SDTMR2_RASMAX_SHIFT) | \
> + (0 << DV_DDR_SDTMR2_XP_SHIFT) | \
> + (0 << DV_DDR_SDTMR2_ODT_SHIFT) | \
> + (17 << DV_DDR_SDTMR2_XSNR_SHIFT) | \
> + (199 << DV_DDR_SDTMR2_XSRD_SHIFT) | \
> + (0 << DV_DDR_SDTMR2_RTP_SHIFT) | \
> + (0 << DV_DDR_SDTMR2_CKE_SHIFT))
Last time I guess I wasn't clear enough, sorry, there's 0 shifts other
places I disagree with two. I really think in some cases we're best off
just saying "Please look@the ... section of the TRM for this part for
an explanation of all bit fields." and not calculate or'ing in 0 here or
there.
--
Tom
next prev parent reply other threads:[~2011-12-05 15:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 10:58 [U-Boot] [PATCH v5 0/6] Add an SPL to boot the da850evm from SPI Christian Riesch
2011-12-05 10:58 ` [U-Boot] [PATCH v5 1/6] spl: display_options.o is required for SPI flash support in SPL Christian Riesch
2011-12-05 10:58 ` [U-Boot] [PATCH v5 2/6] sf: Add spi_boot() to allow booting from SPI flash in an SPL Christian Riesch
2011-12-05 19:33 ` Scott Wood
2011-12-05 19:56 ` Mike Frysinger
2011-12-05 20:03 ` Tom Rini
2011-12-05 21:23 ` Mike Frysinger
2011-12-05 10:58 ` [U-Boot] [PATCH v5 3/6] arm, davinci: Add SPL support for DA850 SoCs Christian Riesch
2011-12-05 10:58 ` [U-Boot] [PATCH v5 4/6] arm, da850evm: Add an SPL for SPI boot Christian Riesch
2011-12-05 15:19 ` Tom Rini [this message]
2011-12-05 10:58 ` [U-Boot] [PATCH v5 5/6] mkimage: Fix variable length header support Christian Riesch
2011-12-05 10:58 ` [U-Boot] [PATCH v5 6/6] arm, davinci: Add support for generating AIS images to the Makefile Christian Riesch
2011-12-05 20:05 ` [U-Boot] [PATCH v5 0/6] Add an SPL to boot the da850evm from SPI Tom Rini
2011-12-06 16:46 ` Tom Rini
2011-12-06 17:08 ` Christian Riesch
2011-12-06 17:14 ` Tom Rini
2011-12-06 17:32 ` Christian Riesch
2011-12-06 17:34 ` Tom Rini
2011-12-06 22:17 ` Tom Rini
2011-12-07 9:32 ` Christian Riesch
2011-12-09 10:36 ` Christian Riesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EDCE0EE.70702@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox