From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 5 Dec 2011 08:19:10 -0700 Subject: [U-Boot] [PATCH v5 4/6] arm, da850evm: Add an SPL for SPI boot In-Reply-To: <1323082732-32682-5-git-send-email-christian.riesch@omicron.at> References: <1323082732-32682-1-git-send-email-christian.riesch@omicron.at> <1323082732-32682-5-git-send-email-christian.riesch@omicron.at> Message-ID: <4EDCE0EE.70702@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 12/05/2011 03:58 AM, Christian Riesch wrote: [snip] > include/configs/da850evm.h | 87 +++++++++++++++++++++++++++++++++ [snip] > +#define CONFIG_SYS_DA850_DDR2_SDTIMR2 ( \ > + (7 << DV_DDR_SDTMR2_RASMAX_SHIFT) | \ > + (0 << DV_DDR_SDTMR2_XP_SHIFT) | \ > + (0 << DV_DDR_SDTMR2_ODT_SHIFT) | \ > + (17 << DV_DDR_SDTMR2_XSNR_SHIFT) | \ > + (199 << DV_DDR_SDTMR2_XSRD_SHIFT) | \ > + (0 << DV_DDR_SDTMR2_RTP_SHIFT) | \ > + (0 << DV_DDR_SDTMR2_CKE_SHIFT)) Last time I guess I wasn't clear enough, sorry, there's 0 shifts other places I disagree with two. I really think in some cases we're best off just saying "Please look@the ... section of the TRM for this part for an explanation of all bit fields." and not calculate or'ing in 0 here or there. -- Tom