public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 8/9] arch/arm/cpu/armv7/omap-common/clocks-common.c: Fix GCC 4.6 warnings
Date: Mon, 5 Dec 2011 10:11:00 -0700	[thread overview]
Message-ID: <4EDCFB24.7000101@ti.com> (raw)
In-Reply-To: <20111205173230.4dd47cea@wker>

On 12/05/2011 09:32 AM, Anatolij Gustschin wrote:
> On Mon, 5 Dec 2011 08:02:53 -0700
> Tom Rini <trini@ti.com> wrote:
> 
>> On 12/03/2011 09:46 AM, Anatolij Gustschin wrote:
>>> Fix:
>>> clocks-common.c: In function 'setup_dplls':
>>> clocks-common.c:256:6: warning: variable 'sysclk_ind' set but not used
>>> [-Wunused-but-set-variable]
>>> clocks-common.c: In function 'setup_non_essential_dplls':
>>> clocks-common.c:292:6: warning: variable 'sysclk_ind' set but not used
>>> [-Wunused-but-set-variable]
>>>
>>> Signed-off-by: Anatolij Gustschin <agust@denx.de>
>>> Cc: sricharan <r.sricharan@ti.com>
>>> Cc: Tom Rini <trini@ti.com>
>>> ---
>>>  arch/arm/cpu/armv7/omap-common/clocks-common.c |    8 +++-----
>>>  1 files changed, 3 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/arch/arm/cpu/armv7/omap-common/clocks-common.c b/arch/arm/cpu/armv7/omap-common/clocks-common.c
>>> index 1e7e20e..1da90a4 100644
>>> --- a/arch/arm/cpu/armv7/omap-common/clocks-common.c
>>> +++ b/arch/arm/cpu/armv7/omap-common/clocks-common.c
>>> @@ -253,11 +253,10 @@ void configure_mpu_dpll(void)
>>>  
>>>  static void setup_dplls(void)
>>>  {
>>> -	u32 sysclk_ind, temp;
>>> +	u32 temp;
>>>  	const struct dpll_params *params;
>>> -	debug("setup_dplls\n");
>>>  
>>> -	sysclk_ind = get_sys_clk_index();
>>> +	debug("setup_dplls\n");
>>>  
>>>  	/* CORE dpll */
>>>  	params = get_core_dpll_params();	/* default - safest */
>>
>> Hand-editing the diffs?  Not sure why the debug print looks like it
>> moved.  But regardless...
> 
> No, not this time. I moved the debug print intentionally to fix the
> coding style, while at it. It doesn't make sense to send separate
> patch for this coding style fix. I should have mentioned this in the
> commit log, sorry.

Ah, OK, now I see it, thanks (and will still merge as-is).

-- 
Tom

  reply	other threads:[~2011-12-05 17:11 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-03 16:46 [U-Boot] [PATCH 1/9] common/menu.c: Fix build warning Anatolij Gustschin
2011-12-03 16:46 ` [U-Boot] [PATCH 2/9] drivers/mtd/nand/nand_spl_simple.c: Fix GCC 4.6 warnings Anatolij Gustschin
2011-12-04  9:07   ` Heiko Schocher
2011-12-04 11:24   ` Marek Vasut
2011-12-07 22:10   ` Scott Wood
2011-12-03 16:46 ` [U-Boot] [PATCH 3/9] drivers/mtd/nand/nand_spl_load.c: Fix GCC 4.6 warning Anatolij Gustschin
2011-12-04  9:15   ` Heiko Schocher
2011-12-04 11:24   ` Marek Vasut
2011-12-07 22:11   ` Scott Wood
2011-12-03 16:46 ` [U-Boot] [PATCH 4/9] drivers/usb/musb/musb_udc.c: " Anatolij Gustschin
2011-12-04 11:10   ` Remy Bohmer
2011-12-04 11:25   ` Marek Vasut
2011-12-09  9:36   ` Wolfgang Denk
2011-12-03 16:46 ` [U-Boot] [PATCH 5/9] drivers/usb/gadget/core.c: " Anatolij Gustschin
2011-12-04 11:06   ` Remy Bohmer
2011-12-04 11:27   ` Marek Vasut
2011-12-09  9:37   ` Wolfgang Denk
2011-12-03 16:46 ` [U-Boot] [PATCH 6/9] drivers/usb/gadget/ep0.c: " Anatolij Gustschin
2011-12-04 11:11   ` Remy Bohmer
2011-12-04 11:28   ` Marek Vasut
2011-12-09  9:37   ` Wolfgang Denk
2011-12-03 16:46 ` [U-Boot] [PATCH 7/9] arch/arm/cpu/armv7/omap-common/spl.c: Fix GCC 4.2 warnings Anatolij Gustschin
2011-12-04 11:28   ` Marek Vasut
2011-12-05 15:04     ` Tom Rini
2011-12-03 16:46 ` [U-Boot] [PATCH 8/9] arch/arm/cpu/armv7/omap-common/clocks-common.c: Fix GCC 4.6 warnings Anatolij Gustschin
2011-12-04 11:29   ` Marek Vasut
2011-12-05 15:02   ` Tom Rini
2011-12-05 16:32     ` Anatolij Gustschin
2011-12-05 17:11       ` Tom Rini [this message]
2011-12-03 16:46 ` [U-Boot] [PATCH 9/9] arch/arm/include/asm/arch-omap5/clocks.h: Fix GCC 4.2 warnings Anatolij Gustschin
2011-12-04 11:30   ` Marek Vasut
2011-12-04 13:59     ` Anatolij Gustschin
2011-12-05 15:08       ` Tom Rini
2011-12-06  5:52         ` R, Sricharan
2011-12-04  9:17 ` [U-Boot] [PATCH 1/9] common/menu.c: Fix build warning Heiko Schocher
2011-12-04 11:27 ` Marek Vasut
2011-12-04 11:49   ` Anatolij Gustschin
2011-12-05 22:26 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EDCFB24.7000101@ti.com \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox