From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 5 Dec 2011 10:11:00 -0700 Subject: [U-Boot] [PATCH 8/9] arch/arm/cpu/armv7/omap-common/clocks-common.c: Fix GCC 4.6 warnings In-Reply-To: <20111205173230.4dd47cea@wker> References: <1322930775-4767-1-git-send-email-agust@denx.de> <1322930775-4767-8-git-send-email-agust@denx.de> <4EDCDD1D.4030408@ti.com> <20111205173230.4dd47cea@wker> Message-ID: <4EDCFB24.7000101@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 12/05/2011 09:32 AM, Anatolij Gustschin wrote: > On Mon, 5 Dec 2011 08:02:53 -0700 > Tom Rini wrote: > >> On 12/03/2011 09:46 AM, Anatolij Gustschin wrote: >>> Fix: >>> clocks-common.c: In function 'setup_dplls': >>> clocks-common.c:256:6: warning: variable 'sysclk_ind' set but not used >>> [-Wunused-but-set-variable] >>> clocks-common.c: In function 'setup_non_essential_dplls': >>> clocks-common.c:292:6: warning: variable 'sysclk_ind' set but not used >>> [-Wunused-but-set-variable] >>> >>> Signed-off-by: Anatolij Gustschin >>> Cc: sricharan >>> Cc: Tom Rini >>> --- >>> arch/arm/cpu/armv7/omap-common/clocks-common.c | 8 +++----- >>> 1 files changed, 3 insertions(+), 5 deletions(-) >>> >>> diff --git a/arch/arm/cpu/armv7/omap-common/clocks-common.c b/arch/arm/cpu/armv7/omap-common/clocks-common.c >>> index 1e7e20e..1da90a4 100644 >>> --- a/arch/arm/cpu/armv7/omap-common/clocks-common.c >>> +++ b/arch/arm/cpu/armv7/omap-common/clocks-common.c >>> @@ -253,11 +253,10 @@ void configure_mpu_dpll(void) >>> >>> static void setup_dplls(void) >>> { >>> - u32 sysclk_ind, temp; >>> + u32 temp; >>> const struct dpll_params *params; >>> - debug("setup_dplls\n"); >>> >>> - sysclk_ind = get_sys_clk_index(); >>> + debug("setup_dplls\n"); >>> >>> /* CORE dpll */ >>> params = get_core_dpll_params(); /* default - safest */ >> >> Hand-editing the diffs? Not sure why the debug print looks like it >> moved. But regardless... > > No, not this time. I moved the debug print intentionally to fix the > coding style, while at it. It doesn't make sense to send separate > patch for this coding style fix. I should have mentioned this in the > commit log, sorry. Ah, OK, now I see it, thanks (and will still merge as-is). -- Tom