public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] arm, arm926ejs: always do cpu critical inits
Date: Mon, 05 Dec 2011 18:11:29 +0100	[thread overview]
Message-ID: <4EDCFB41.2000404@aribaud.net> (raw)
In-Reply-To: <CA+M6bX=u3nE9FKqiu050M6_1UxwoFo5GxvyNU36Kegbmw=H9pA@mail.gmail.com>

Le 29/11/2011 20:27, Tom Rini a ?crit :
> On Wed, Nov 9, 2011 at 11:06 PM, Heiko Schocher<hs@denx.de>  wrote:
>> always do the cpu critical inits in cpu_init_crit,
>> and only jump to lowlevel_init, if CONFIG_SKIP_LOWLEVEL_INIT
>> is not defined.
>>
>> Signed-off-by: Heiko Schocher<hs@denx.de>
>> Cc: Albert ARIBAUD<albert.u.boot@aribaud.net>
>> Cc: Wolfgang Denk<hs@denx.de>
>> Cc: Sandeep Paulraj<s-paulraj@ti.com>
>> Cc: Tom Rini<tom.rini@gmail.com>
>> Cc: Christian Riesch<christian.riesch@omicron.at>
>
> (Will be) queued to u-boot-ti, thanks.

Hmm... This commit alters the effect of CONFIG_SKIP_LOWLEVEL_INIT 
without making it possible to recreate it through configuration -- you 
now have to alter the source code to get the same effect as before. I'd 
prefer the CPU init crit code to be kept under a config option, and 
another option to be added for finer control.

Amicalement,
-- 
Albert.

  reply	other threads:[~2011-12-05 17:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-10  6:06 [U-Boot] [PATCH 0/2] arm, davinci: da850/dm365 lowlevel cleanup Heiko Schocher
2011-11-10  6:06 ` [U-Boot] [PATCH 1/2] arm, arm926ejs: always do cpu critical inits Heiko Schocher
2011-11-29 19:27   ` Tom Rini
2011-12-05 17:11     ` Albert ARIBAUD [this message]
2011-12-06  6:39       ` Heiko Schocher
2011-11-10  6:06 ` [U-Boot] [PATCH 2/2] arm, davinci: da850/dm365 lowlevel cleanup Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EDCFB41.2000404@aribaud.net \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox