public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 10/17] tegra: usb: fdt: Add USB definitions for Tegra2 Seaboard
Date: Mon, 05 Dec 2011 16:26:49 -0700	[thread overview]
Message-ID: <4EDD5339.4080202@nvidia.com> (raw)
In-Reply-To: <1322878300-5551-11-git-send-email-sjg@chromium.org>

On 12/02/2011 07:11 PM, Simon Glass wrote:
> We set up two USB ports, one of which can be host or device.
> For some reason the kernel version does enable both ports.

> +++ b/board/nvidia/dts/tegra2-seaboard.dts

> @@ -11,6 +11,12 @@
>  		bootargs = "vmalloc=192M video=tegrafb console=ttyS0,115200n8 root=/dev/mmcblk1p3 rw rootwait";
>  	};
>  
> +        aliases {
> +		/* This defines the order of our USB ports */
> +                usb0 = "/usb at c5008000";
> +                usb1 = "/usb at c5000000";
> +        };
> +

That's indented with spaces instead of TABs.

>  	memory {
>  		device_type = "memory";
>  		reg = < 0x00000000 0x40000000 >;
> @@ -31,6 +37,12 @@
>  	};
>  
>  	usb at c5000000 {
> -		nvidia,vbus-gpio = <&gpio 24 0>; /* PD0 */
> +		nvidia,vbus-gpio = <&gpio 24 1>; /* PD0 high to enable vbus */
> +		support-host-mode;
> +		status = "okay";

That's the default, and tegra20.dtsi doesn't specify status =
"disabled", so the status properties are redundant. You may want to
specify a disabled status in tegra-seaboard.dts for the other USB port
if it isn't used though.

> +	};
> +
> +	usb at c5008000 {
> +		status = "okay";
>  	};
>  };

-- 
nvpublic

  reply	other threads:[~2011-12-05 23:26 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-03  2:11 [U-Boot] [PATCH v2 0/17] tegra: Add fdt definitions and USB driver Simon Glass
2011-12-03  2:11 ` [U-Boot] [PATCH v2 01/17] fdt: Tidy up a few fdtdec problems Simon Glass
2011-12-05 21:27   ` Stephen Warren
2011-12-05 21:40     ` Simon Glass
2011-12-05 22:07       ` Stephen Warren
2011-12-05 22:11         ` Simon Glass
2011-12-05 22:18           ` Scott Wood
2011-12-05 22:25             ` Stephen Warren
2011-12-05 22:53               ` Simon Glass
2011-12-03  2:11 ` [U-Boot] [PATCH v2 02/17] fdt: Add functions to access phandles, arrays and bools Simon Glass
2011-12-05 21:59   ` Stephen Warren
2011-12-05 22:07     ` Simon Glass
2011-12-05 22:36       ` Stephen Warren
2011-12-05 23:56         ` Simon Glass
2011-12-03  2:11 ` [U-Boot] [PATCH v2 03/17] Add gpio_request() to asm-generic header Simon Glass
2011-12-03  2:11 ` [U-Boot] [PATCH v2 04/17] fdt: Add basic support for decoding GPIO definitions Simon Glass
2011-12-05 21:46   ` Stephen Warren
2011-12-05 21:56     ` Simon Glass
2011-12-05 22:22       ` Stephen Warren
2011-12-05 22:52         ` Simon Glass
2011-12-05 23:03           ` Stephen Warren
2011-12-05 23:29             ` Simon Glass
2011-12-06  3:55           ` Mike Frysinger
2011-12-07  1:21             ` Simon Glass
2011-12-03  2:11 ` [U-Boot] [PATCH v2 05/17] arm: fdt: Ensure that an embedded fdt is word-aligned Simon Glass
2011-12-03  2:11 ` [U-Boot] [PATCH v2 06/17] arm: fdt: Add skeleton device tree file from kernel Simon Glass
2011-12-03  2:11 ` [U-Boot] [PATCH v2 07/17] tegra: fdt: Add Tegra2x " Simon Glass
2011-12-03  2:11 ` [U-Boot] [PATCH v2 08/17] tegra: fdt: Add device tree file for Tegra2 Seaboard " Simon Glass
2011-12-03  2:11 ` [U-Boot] [PATCH v2 09/17] tegra: usb: fdt: Add additional device tree definitions for USB ports Simon Glass
2011-12-05 23:25   ` Stephen Warren
2011-12-06  0:55     ` Simon Glass
2011-12-06 20:28       ` Stephen Warren
2011-12-06 21:09         ` Simon Glass
2011-12-07 23:36           ` Stephen Warren
2011-12-08 21:10             ` Simon Glass
2011-12-12 18:13               ` Stephen Warren
2011-12-12 18:53                 ` Simon Glass
2011-12-03  2:11 ` [U-Boot] [PATCH v2 10/17] tegra: usb: fdt: Add USB definitions for Tegra2 Seaboard Simon Glass
2011-12-05 23:26   ` Stephen Warren [this message]
2011-12-03  2:11 ` [U-Boot] [PATCH v2 11/17] usb: Add support for data alignment Simon Glass
2011-12-04 11:13   ` Remy Bohmer
2011-12-06  2:38     ` Simon Glass
2011-12-10 16:04       ` Remy Bohmer
2011-12-10 18:58         ` Simon Glass
2011-12-03  2:11 ` [U-Boot] [PATCH v2 12/17] usb: Add support for txfifo threshold Simon Glass
2011-12-05 23:32   ` Stephen Warren
2011-12-06  2:03     ` Simon Glass
2011-12-06 18:58       ` Stephen Warren
2011-12-06 19:24         ` Simon Glass
2011-12-03  2:11 ` [U-Boot] [PATCH v2 13/17] tegra: usb: Add support for Tegra USB peripheral Simon Glass
2011-12-04 11:12   ` Remy Bohmer
2011-12-03  2:11 ` [U-Boot] [PATCH v2 14/17] tegra: usb: Add USB support to nvidia boards Simon Glass
2011-12-03  2:11 ` [U-Boot] [PATCH v2 15/17] tegra: usb: Add common USB defines for tegra2 boards Simon Glass
2011-12-03  2:11 ` [U-Boot] [PATCH v2 16/17] tegra: usb: Enable USB on Seaboard Simon Glass
2011-12-03  2:11 ` [U-Boot] [PATCH v2 17/17] tegra: fdt: Enable FDT support for Seaboard Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EDD5339.4080202@nvidia.com \
    --to=swarren@nvidia.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox