From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Mon, 05 Dec 2011 16:32:00 -0700 Subject: [U-Boot] [PATCH v2 12/17] usb: Add support for txfifo threshold In-Reply-To: <1322878300-5551-13-git-send-email-sjg@chromium.org> References: <1322878300-5551-1-git-send-email-sjg@chromium.org> <1322878300-5551-13-git-send-email-sjg@chromium.org> Message-ID: <4EDD5470.9080405@nvidia.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 12/02/2011 07:11 PM, Simon Glass wrote: > CONFIG_USB_EHCI_TXFIFO_THRESH enables setting of the txfilltuning > field in the EHCI controller on reset. > diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h > index 3d0ad0c..cc00ce4 100644 > --- a/drivers/usb/host/ehci.h > +++ b/drivers/usb/host/ehci.h > @@ -80,7 +80,11 @@ struct ehci_hcor { > uint32_t or_ctrldssegment; > uint32_t or_periodiclistbase; > uint32_t or_asynclistaddr; > - uint32_t _reserved_[9]; > + uint32_t _reserved_0_; Why not remove _reserved_0_ ... > + uint32_t or_burstsize; > + uint32_t or_txfilltuning; > +#define TXFIFO_THRESH(p) ((p & 0x3f) << 16) > + uint32_t _reserved_1_[6]; ... and make _reserved_1_ 1 element bigger and keep it named _reserved_? The result would be a little simpler. > uint32_t or_configflag; > #define FLAG_CF (1 << 0) /* true: we'll support "high speed" */ > uint32_t or_portsc[CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS]; -- nvpublic