public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Thomas Weber <weber@corscience.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] devkit8000: Move CONFIG_SYS_TEXT_BASE out of bss
Date: Tue, 06 Dec 2011 14:52:02 +0100	[thread overview]
Message-ID: <4EDE1E02.1030704@corscience.de> (raw)
In-Reply-To: <1323162988-8873-1-git-send-email-simonschwarzcor@gmail.com>

On 06.12.2011 10:16, Simon Schwarz wrote:
> This moves CONFIG_SYS_TEXT_BASE one MB after beginning of SD-RAM. Move
> CONFIG_SYS_SPL_MALLOC_START to have one MB of free space for the u-boot
> image.
> 
> CONFIG_SYS_TEXT_BASE was in the middle of the bss-section. This was the
> reason for the problems with MMC boot described here:
> http://article.gmane.org/gmane.comp.boot-loaders.u-boot/118711
> 
> Signed-off-by: Simon Schwarz <simonschwarzcor@gmail.com>
> ---
> V2 changes:
> CHG added a more comprehensive comment on CONFIG_SYS_TEXT_BASE
> CHG Moved CONFIG_SYS_SPL_MALLOC_START from 0x80200000 to 0x80208000 to be
>   		consistent with beagle board
> 
> Cc: s-paulraj at ti.com
> Cc: trini at ti.com
> Cc: albert.u.boot at aribaud.net
> ---
>  include/configs/devkit8000.h |   10 ++++++++--
>  1 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/include/configs/devkit8000.h b/include/configs/devkit8000.h
> index e1743dc..a2e1d2d 100644
> --- a/include/configs/devkit8000.h
> +++ b/include/configs/devkit8000.h
> @@ -37,7 +37,13 @@
>  #define CONFIG_OMAP3430		1	/* which is in a 3430 */
>  #define CONFIG_OMAP3_DEVKIT8000	1	/* working with DevKit8000 */
>  
> -#define	CONFIG_SYS_TEXT_BASE	0x80008000
> +/*
> + * 1MB into the SDRAM to allow for SPL's bss at the beginning of SDRAM
> + * 64 bytes before this address should be set aside for u-boot.img's
> + * header. That is 0x800FFFC0--0x80100000 should not be used for any
> + * other needs.
> + */
> +#define	CONFIG_SYS_TEXT_BASE	0x80100000
>  
>  #define CONFIG_SDRC	/* The chip has SDRC controller */
>  
> @@ -359,7 +365,7 @@
>  #define CONFIG_SYS_NAND_U_BOOT_OFFS	0x80000
>  #define CONFIG_SYS_NAND_U_BOOT_SIZE	0x200000
>  
> -#define CONFIG_SYS_SPL_MALLOC_START	0x80108000
> +#define CONFIG_SYS_SPL_MALLOC_START	0x80208000
>  #define CONFIG_SYS_SPL_MALLOC_SIZE	0x100000	/* 1 MB */
>  
>  #endif /* __CONFIG_H */

Tested-by: Thomas Weber <weber@corscience.de>

Thanks,
Thomas

      reply	other threads:[~2011-12-06 13:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-30 17:05 [U-Boot] [PATCH] devkit8000: Move CONFIG_SYS_TEXT_BASE out of bss Simon Schwarz
2011-11-30 17:12 ` Simon Schwarz
2011-11-30 17:20 ` Tom Rini
2011-12-01  7:49 ` Igor Grinberg
2011-12-01  9:07   ` Simon Schwarz
2011-12-01 10:03     ` Igor Grinberg
2011-12-01 10:16       ` Aneesh V
2011-12-01 11:04         ` Igor Grinberg
2011-12-01  8:47 ` Thomas Weber
2011-12-06  9:16 ` [U-Boot] [PATCH V2] " Simon Schwarz
2011-12-06 13:52   ` Thomas Weber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EDE1E02.1030704@corscience.de \
    --to=weber@corscience.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox