From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 10/10] Convert cmd_usage() calls in common to use a return value
Date: Wed, 07 Dec 2011 14:47:47 +0200 [thread overview]
Message-ID: <4EDF6073.7030600@compulab.co.il> (raw)
In-Reply-To: <1323236876-9100-11-git-send-email-sjg@chromium.org>
Hi Simon,
On 12/07/11 07:47, Simon Glass wrote:
> Change all files in common/ to use CMD_RET_USAGE instead of calling
> cmd_usage() directly. I'm not completely sure about this patch since
> the code since impact is small (100 byte or so on ARM) and it might
> need splitting into smaller patches. But for now here it is.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
[...]
> diff --git a/common/cmd_mmc_spi.c b/common/cmd_mmc_spi.c
> index cfd0fb1..3153610 100644
> --- a/common/cmd_mmc_spi.c
> +++ b/common/cmd_mmc_spi.c
> @@ -78,7 +78,7 @@ static int do_mmc_spi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> return 0;
>
> usage:
> - cmd_usage(cmdtp);
> + return CMD_RET_USAGE;
> return 1;
You, probably, also want to remove the above line...
[...]
--
Regards,
Igor.
next prev parent reply other threads:[~2011-12-07 12:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 5:47 [U-Boot] [PATCH 0/10] Unified command execution in one place Simon Glass
2011-12-07 5:47 ` [U-Boot] [PATCH 01/10] Remove CMD_PXE's static on run_command() Simon Glass
2011-12-07 5:47 ` [U-Boot] [PATCH 02/10] Rename run_command() to builtin_run_command() Simon Glass
2011-12-07 5:47 ` [U-Boot] [PATCH 03/10] Rename run_command2() to run_command() Simon Glass
2011-12-07 5:47 ` [U-Boot] [PATCH 04/10] Stop using builtin_run_command() Simon Glass
2011-12-07 5:47 ` [U-Boot] [PATCH 05/10] Don't include standard parser if hush is used Simon Glass
2011-12-07 5:47 ` [U-Boot] [PATCH 06/10] Create a single cmd_call() function to handle command execution Simon Glass
2011-12-07 5:47 ` [U-Boot] [PATCH 07/10] Remove interleave of non-U-Boot code in hush Simon Glass
2011-12-07 5:47 ` [U-Boot] [PATCH 08/10] Add cmd_process() to process commands in one place Simon Glass
2011-12-07 5:47 ` [U-Boot] [PATCH 09/10] Use CMD_RET_usage in i2c Simon Glass
2011-12-07 7:16 ` Heiko Schocher
2011-12-07 16:17 ` Simon Glass
2011-12-07 5:47 ` [U-Boot] [PATCH 10/10] Convert cmd_usage() calls in common to use a return value Simon Glass
2011-12-07 12:47 ` Igor Grinberg [this message]
2011-12-07 16:29 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EDF6073.7030600@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox