From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Grinberg Date: Wed, 07 Dec 2011 14:47:47 +0200 Subject: [U-Boot] [PATCH 10/10] Convert cmd_usage() calls in common to use a return value In-Reply-To: <1323236876-9100-11-git-send-email-sjg@chromium.org> References: <1323236876-9100-1-git-send-email-sjg@chromium.org> <1323236876-9100-11-git-send-email-sjg@chromium.org> Message-ID: <4EDF6073.7030600@compulab.co.il> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, On 12/07/11 07:47, Simon Glass wrote: > Change all files in common/ to use CMD_RET_USAGE instead of calling > cmd_usage() directly. I'm not completely sure about this patch since > the code since impact is small (100 byte or so on ARM) and it might > need splitting into smaller patches. But for now here it is. > > Signed-off-by: Simon Glass > --- [...] > diff --git a/common/cmd_mmc_spi.c b/common/cmd_mmc_spi.c > index cfd0fb1..3153610 100644 > --- a/common/cmd_mmc_spi.c > +++ b/common/cmd_mmc_spi.c > @@ -78,7 +78,7 @@ static int do_mmc_spi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) > return 0; > > usage: > - cmd_usage(cmdtp); > + return CMD_RET_USAGE; > return 1; You, probably, also want to remove the above line... [...] -- Regards, Igor.