From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Wed, 7 Dec 2011 12:18:45 -0600 Subject: [U-Boot] [PATCH 11/13] nand_spl_simple: store temp data at CONFIG_SPL_NAND_WORKSPACE In-Reply-To: <4EDFA65E.8080809@emcraft.com> References: <1322498261-20645-1-git-send-email-yanok@emcraft.com> <1322498261-20645-12-git-send-email-yanok@emcraft.com> <4EDF2C8E.7090002@denx.de> <4EDFA65E.8080809@emcraft.com> Message-ID: <4EDFAE05.3070106@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 12/07/2011 11:46 AM, Ilya Yanok wrote: > Hi Stefano, > > On 07.12.2011 13:06, Stefano Babic wrote: >>> +#ifndef CONFIG_SPL_NAND_WORKSPACE >>> +#define CONFIG_SPL_NAND_WORKSPACE (CONFIG_SYS_SDRAM_BASE + 0x10000) >>> +#endif >> >> Maybe it is better to not have a default value somewhere in the SDRAM >> and to get a compile error. If we do not want to fix also the related > > My intention was not to break something as I can't fix every board using > this driver. That's why I preserved the existing address for the case > where CONFIG_SPL_NAND_WORKSPACE is not defined. How many boards are using the new SPL for NAND so far? It shouldn't be that bad to just fix them. -Scott