From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ilya Yanok Date: Wed, 07 Dec 2011 23:05:07 +0400 Subject: [U-Boot] [PATCH 11/13] nand_spl_simple: store temp data at CONFIG_SPL_NAND_WORKSPACE In-Reply-To: <20111207184542.2AF591A32821@gemini.denx.de> References: <1322498261-20645-1-git-send-email-yanok@emcraft.com> <1322498261-20645-12-git-send-email-yanok@emcraft.com> <4EDF2C8E.7090002@denx.de> <4EDFA65E.8080809@emcraft.com> <20111207184542.2AF591A32821@gemini.denx.de> Message-ID: <4EDFB8E3.8090408@emcraft.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Wolfgang, On 07.12.2011 22:45, Wolfgang Denk wrote: >>> boards, we could at least use a #warn message to advise at compile time >>> that a default value is taken (and at the end, to force the board >>> maintainers to fix it...). >> >> Probably. Wolfgang, Scott, do you think we should add a warning here? > > How much space are we talking about? Can it be put on the stack? Well, currently the code uses 0x200 + CONFIG_SYS_NAND_OOBSIZE bytes but I think a lot of this space is unused. What we really need is CONFIG_SYS_NAND_ECCTOTAL + CONFIG_SYS_NAND_OOBSIZE. This is probably acceptable to put on the stack. Regards, Ilya.