public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/6] tegra: Add tegra keyboard support
Date: Wed, 07 Dec 2011 15:02:01 -0700	[thread overview]
Message-ID: <4EDFE259.9080201@nvidia.com> (raw)
In-Reply-To: <1322881071-11148-5-git-send-email-sjg@chromium.org>

On 12/02/2011 07:57 PM, Simon Glass wrote:
> Add support for internal matrix keyboard controller for Nvidia Tegra platforms.
> This driver uses the fdt decode function to obtain its key codes.

> +static int fdt_decode_kbc(const void *blob, int node, struct keyb *config)
> +{
> +       config->kbc = (struct kbc_tegra *)fdtdec_get_addr(blob, node, "reg");
> +       config->plain_keycode = fdtdec_locate_byte_array(blob, node,
> +                               "keycode-plain", KBC_KEY_COUNT);
> +       config->shift_keycode = fdtdec_locate_byte_array(blob, node,
> +                               "keycode-shift", KBC_KEY_COUNT);
> +       config->fn_keycode = fdtdec_locate_byte_array(blob, node,
> +                               "keycode-fn", KBC_KEY_COUNT);
> +       config->ctrl_keycode = fdtdec_locate_byte_array(blob, node,
> +                               "keycode-ctrl", KBC_KEY_COUNT);
> +       if (!config->plain_keycode) {
> +               debug("%s: cannot find keycode-plain map\n", __func__);
> +               return -1;
> +       }
> +       return 0;
> +}

Simon,

Sorry to keep pushing back on everything so much, but I don't believe
the structure of this binding is correct.

  reply	other threads:[~2011-12-07 22:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-03  2:57 [U-Boot] [PATCH 0/6] tegra: Enable keyboard with matrix keyboard driver Simon Glass
2011-12-03  2:57 ` [U-Boot] [PATCH 1/6] tegra: fdt: Add keyboard controller definition Simon Glass
2011-12-03  2:57 ` [U-Boot] [PATCH 2/6] tegra: fdt: Add keyboard definitions for Seaboard Simon Glass
2011-12-05 23:49   ` Stephen Warren
2011-12-03  2:57 ` [U-Boot] [PATCH 3/6] fdt: Add fdtdec functions to read byte array Simon Glass
2011-12-05 23:54   ` Stephen Warren
2011-12-06  0:27     ` Simon Glass
2011-12-03  2:57 ` [U-Boot] [PATCH 4/6] tegra: Add tegra keyboard support Simon Glass
2011-12-07 22:02   ` Stephen Warren [this message]
2011-12-08 21:56     ` Simon Glass
2011-12-12 18:00       ` Stephen Warren
2011-12-12 18:10         ` Simon Glass
2011-12-12 18:31           ` Stephen Warren
2011-12-12 20:03             ` Simon Glass
2011-12-03  2:57 ` [U-Boot] [PATCH 5/6] tegra: Switch on console mux and use environment for console Simon Glass
2011-12-03  2:57 ` [U-Boot] [PATCH 6/6] tegra: Enable keyboard for Seaboard Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EDFE259.9080201@nvidia.com \
    --to=swarren@nvidia.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox