From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Babic <sbabic@denx.de>
Date: Fri, 09 Dec 2011 11:37:49 +0100
Subject: [U-Boot] [PATCH] M28: Cleanup memsize.o OOT build
In-Reply-To: <201112091048.15008.marek.vasut@gmail.com>
References: <1323347237-6021-1-git-send-email-marek.vasut@gmail.com>
	<4EE1D16D.6050003@denx.de>
	<201112091048.15008.marek.vasut@gmail.com>
Message-ID: <4EE1E4FD.40907@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 09/12/2011 10:48, Marek Vasut wrote:
>> On 08/12/2011 13:27, Marek Vasut wrote:
>>> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
>>> Cc: Wolfgang Denk <wd@denx.de>
>>> Cc: Detlev Zundel <dzu@denx.de>
>>> Cc: Stefano Babic <sbabic@denx.de>
>>> ---
>>
>> Hi Marek,
>>
>>>  arch/arm/cpu/arm926ejs/mx28/Makefile       |    7 +------
>>>  arch/arm/cpu/arm926ejs/mx28/spl_boot.c     |   13 ++-----------
>>>  arch/arm/cpu/arm926ejs/mx28/u-boot-spl.lds |   12 ++++++------
>>>  include/configs/m28evk.h                   |    2 ++
>>>  4 files changed, 11 insertions(+), 23 deletions(-)
>>
>> It seems to me that your patch does much more as what you describe in
>> the commit message.
> 
> Please check V2


Ah, ok, I see it.

>>> -inline int printf(const char *fmt, ...)
>>> -{
>>> -	return 0;
>>> -}
>>> -
>>> -inline void __coloured_LED_init(void) {}
>>> -inline void __red_LED_on(void) {}
>>> -void coloured_LED_init(void)
>>> -	__attribute__((weak, alias("__coloured_LED_init")));
>>> -void red_LED_on(void)
>>> -	__attribute__((weak, alias("__red_LED_on")));
>>> +void serial_putc(const char c) {}
>>> +void serial_puts(const char *s) {}
>>
>> Make a note in the commit message about these changes (not related to
>> the subject)
> 
> Actually I explained this in V2.

Ok, it is enough

>>>  	/DISCARD/ : { *(.dynstr*) }
>>>  	/DISCARD/ : { *(.dynsym*) }
>>>  	/DISCARD/ : { *(.dynamic*) }
>>
>> However, these change fix another issue.
> 
> Not really actually.
> 
>> You want to cleanup
>> u-boot-spl.lds, but then there are some other parts I cannot understand.
>> For example, why is __u_boot_cmd_start = needed ?
> 
> Well, u-boot-spl.lds will need a separate cleanup patch eventually maybe.
>>
>> If your goal is to cleanup the linker file, please submit a separate
>> patch removing also the unused sections in SPL.
> 
> Not now, right now my goal is to fix the build issue. Linker file cleanup can 
> wait after .12 release.

Ok, well - I will merge it into u-boot-imx.

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================