From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Sun, 11 Dec 2011 15:16:44 +0100 Subject: [U-Boot] [PATCH v2 4/6] reboard: arm: Add processor function library In-Reply-To: <1323544576-25940-5-git-send-email-sjg@chromium.org> References: <1323544576-25940-1-git-send-email-sjg@chromium.org> <1323544576-25940-5-git-send-email-sjg@chromium.org> Message-ID: <4EE4BB4C.9030208@aribaud.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, Le 10/12/2011 20:16, Simon Glass a ?crit : > Add a library to hold ARM assembler code which is generic across all > ARM CPUs. At first it just holds some basic relocation code. The > plan is to move more start.S code here. I still don't see the point in this new file, as this code is common across all ARM boards and start.S already has much of such common code. I'd rather see start.S keeping the common code and moving up the hierarchy, and and the {ISA, core, SoC, board} specific code be moved out of start.S and down into their 'natural' specific location. Amicalement, -- Albert.