From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/6] reboard: Create reloc.h and include it where needed
Date: Sun, 11 Dec 2011 23:29:52 +0100 [thread overview]
Message-ID: <4EE52EE0.9080109@aribaud.net> (raw)
In-Reply-To: <CALButCJD3=rDKrLCrUwBgxNFruq9U-Q-3rBhSjCyfP8hTWdZbg@mail.gmail.com>
Hi Gream,
Le 11/12/2011 22:45, Graeme Russ a ?crit :
> I think the point is that when we pull stuff out of common.h into,
> say, foo.h then only include foo.h where the functionality moved into
> foo.h is _currently_ used.
>
> It looks like you've pulled out the functions definitions into reloc.h
> then included reloc.h everywhere (including common.h). Better would be
> to moved the definitions to reloc.h, do not include reloc.h in
> common.h and include reloc.h only where it is strictly needed right
> now - Add #include<reloc.h> to each arch file as and when it is
> needed
Thanks Greame. This is indeed what I meant.
> Regards,
>
> Graeme
Amicalement,
--
Albert.
next prev parent reply other threads:[~2011-12-11 22:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-10 19:16 [U-Boot] [PATCH v2 0/6] reboard: Introduce generic relocation feature Simon Glass
2011-12-10 19:16 ` [U-Boot] [PATCH v2 1/6] reboard: Create reloc.h and include it where needed Simon Glass
2011-12-11 14:52 ` Albert ARIBAUD
2011-12-11 21:33 ` Simon Glass
2011-12-11 21:45 ` Albert ARIBAUD
2011-12-11 21:45 ` Graeme Russ
2011-12-11 22:29 ` Albert ARIBAUD [this message]
2011-12-11 22:31 ` Albert ARIBAUD
2011-12-12 5:02 ` Simon Glass
2011-12-10 19:16 ` [U-Boot] [PATCH v2 2/6] reboard: define CONFIG_SYS_SKIP_RELOC for all archs Simon Glass
2011-12-11 14:57 ` Albert ARIBAUD
2011-12-12 5:06 ` Simon Glass
2011-12-10 19:16 ` [U-Boot] [PATCH v2 3/6] reboard: Add generic relocation feature Simon Glass
2011-12-10 19:16 ` [U-Boot] [PATCH v2 4/6] reboard: arm: Add processor function library Simon Glass
2011-12-11 14:16 ` Albert ARIBAUD
2011-12-12 5:24 ` Simon Glass
2011-12-22 6:23 ` Simon Glass
2011-12-10 19:16 ` [U-Boot] [PATCH v2 5/6] reboard: arm: Move over to generic relocation Simon Glass
2011-12-10 19:16 ` [U-Boot] [PATCH v2 6/6] reboard: arm: Remove unused code in start.S Simon Glass
2011-12-11 14:59 ` Albert ARIBAUD
2011-12-12 5:09 ` Simon Glass
2011-12-11 14:47 ` [U-Boot] [PATCH v2 0/6] reboard: Introduce generic relocation feature Albert ARIBAUD
2011-12-11 21:30 ` Simon Glass
2011-12-11 22:27 ` Albert ARIBAUD
2011-12-12 5:20 ` Simon Glass
2011-12-12 5:58 ` Graeme Russ
2011-12-16 1:09 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE52EE0.9080109@aribaud.net \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox