From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
Date: Sun, 11 Dec 2011 23:29:52 +0100
Subject: [U-Boot] [PATCH v2 1/6] reboard: Create reloc.h and include it
	where needed
In-Reply-To: <CALButCJD3=rDKrLCrUwBgxNFruq9U-Q-3rBhSjCyfP8hTWdZbg@mail.gmail.com>
References: <1323544576-25940-1-git-send-email-sjg@chromium.org>
	<1323544576-25940-2-git-send-email-sjg@chromium.org>
	<4EE4C3AE.1060208@aribaud.net>
	<CAPnjgZ1fmxz4wwcgzBJ7u=jPKGEOceAotgaN7tDj3qhyYNxaJQ@mail.gmail.com>
	<CALButCJD3=rDKrLCrUwBgxNFruq9U-Q-3rBhSjCyfP8hTWdZbg@mail.gmail.com>
Message-ID: <4EE52EE0.9080109@aribaud.net>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Gream,

Le 11/12/2011 22:45, Graeme Russ a ?crit :

> I think the point is that when we pull stuff out of common.h into,
> say, foo.h then only include foo.h where the functionality moved into
> foo.h is _currently_ used.
>
> It looks like you've pulled out the functions definitions into reloc.h
> then included reloc.h everywhere (including common.h). Better would be
> to moved the definitions to reloc.h, do not include reloc.h in
> common.h and include reloc.h only where it is strictly needed right
> now - Add #include<reloc.h>  to each arch file as and when it is
> needed

Thanks Greame. This is indeed what I meant.

> Regards,
>
> Graeme

Amicalement,
-- 
Albert.