From: Ilya Yanok <yanok@emcraft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] nand_spl_simple: store ecc data on the stack
Date: Mon, 12 Dec 2011 04:08:57 +0400 [thread overview]
Message-ID: <4EE54619.1070000@emcraft.com> (raw)
In-Reply-To: <1323624146-8402-1-git-send-email-sbabic@denx.de>
Hi Stefano,
thanks for posting this. There is a couple of comments below.
On 11.12.2011 21:22, Stefano Babic wrote:
> diff --git a/drivers/mtd/nand/nand_spl_simple.c b/drivers/mtd/nand/nand_spl_simple.c
> index ed821f2..a3d1af0 100644
> --- a/drivers/mtd/nand/nand_spl_simple.c
> +++ b/drivers/mtd/nand/nand_spl_simple.c
> @@ -145,9 +145,9 @@ static int nand_is_bad_block(int block)
> static int nand_read_page(int block, int page, uchar *dst)
> {
> struct nand_chip *this = mtd.priv;
> - u_char *ecc_calc;
> - u_char *ecc_code;
> - u_char *oob_data;
> + u_char ecc_calc[CONFIG_SYS_NAND_ECCSTEPS * CONFIG_SYS_NAND_ECCBYTES];
> + u_char ecc_code[CONFIG_SYS_NAND_ECCTOTAL];
Doesn't ECCTOTAL always equal to ECCSTEPS * ECCBYTES?
> + u_char oob_data[CONFIG_SYS_NAND_OOBSIZE];
I think we can save a few bytes by placing ecc_code and oob_data into a
union. We only need oob_data to get ecc_code...
Regards, Ilya.
next prev parent reply other threads:[~2011-12-12 0:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-11 17:22 [U-Boot] [PATCH] nand_spl_simple: store ecc data on the stack Stefano Babic
2011-12-12 0:08 ` Ilya Yanok [this message]
2011-12-13 10:33 ` Stefano Babic
2011-12-13 11:30 ` [U-Boot] [PATCH V2] " Stefano Babic
2011-12-13 15:58 ` Tom Rini
2011-12-13 17:31 ` Stefano Babic
2011-12-13 17:50 ` [U-Boot] [PATCH V3] " Stefano Babic
2011-12-13 18:04 ` Tom Rini
2011-12-13 18:18 ` Wolfgang Denk
2011-12-13 18:33 ` Tom Rini
2011-12-13 18:45 ` Scott Wood
2011-12-13 18:54 ` Tom Rini
2011-12-13 19:26 ` Stefano Babic
2011-12-13 18:48 ` stefano babic
2011-12-13 18:52 ` Scott Wood
2011-12-13 18:54 ` Tom Rini
2011-12-13 18:47 ` Scott Wood
2011-12-13 19:33 ` [U-Boot] [PATCH V4] " Stefano Babic
2011-12-13 21:30 ` Tom Rini
2011-12-14 8:22 ` Simon Schwarz
2011-12-14 8:49 ` Stefano Babic
[not found] ` <4EE9B7F8.5060305@gmail.com>
2011-12-15 9:53 ` Stefano Babic
2012-01-10 23:01 ` Scott Wood
2012-01-10 23:24 ` Tom Rini
2012-02-03 20:17 ` Albert ARIBAUD
2012-02-03 21:47 ` Tom Rini
2011-12-15 9:55 ` [U-Boot] [PATCH V5] " Stefano Babic
2011-12-15 22:18 ` Scott Wood
2012-01-05 23:12 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE54619.1070000@emcraft.com \
--to=yanok@emcraft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox