From: "Matthias Weißer" <weisserm@arcor.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm926ejs: remove noop flush_dcache_all function
Date: Mon, 12 Dec 2011 10:20:09 +0100 [thread overview]
Message-ID: <4EE5C749.8000206@arcor.de> (raw)
In-Reply-To: <1323644968-5573-1-git-send-email-yanok@emcraft.com>
Am 12.12.2011 00:09, schrieb Ilya Yanok:
> Commit 2f3427c added noop cache functions implementation for arm926ejs
> to fix compilation of drivers depending on these functions (DaVinci
> EMAC in particular).
>
> Unfortunately, the bug was introduced: noop implementation calls
> dcache_disable which calls flush_dcache_all which in turn calls
> dcache_disable thus creating an infinite loop.
>
> This patch removes noop implementation for flush_dcache_all, we already
> have default one in arch/arm/lib/cache.c and it should be used instead.
>
> Signed-off-by: Ilya Yanok<yanok@emcraft.com>
> ---
>
> Hi Matthias,
>
> thanks for cathing this. Surely my initial patch was totally wrong.
> Could you please test this one?
This patches solves at least my problem. Thanks.
Tested-by: Matthias Weisser <weisserm@arcor.de>
Matthias
next prev parent reply other threads:[~2011-12-12 9:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 14:24 [U-Boot] Cache function change breaks zmx25 Matthias Weißer
2011-12-09 15:03 ` Ilya Yanok
2011-12-10 16:36 ` Matthias Weisser
2011-12-11 23:09 ` [U-Boot] [PATCH] arm926ejs: remove noop flush_dcache_all function Ilya Yanok
2011-12-12 9:20 ` Matthias Weißer [this message]
2011-12-13 18:43 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE5C749.8000206@arcor.de \
--to=weisserm@arcor.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox