From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ilya Yanok Date: Mon, 12 Dec 2011 19:39:35 +0400 Subject: [U-Boot] [PATCH 13/13] mcx: support for HTKW mcx board In-Reply-To: <4ED5E798.2020806@compulab.co.il> References: <1322498261-20645-1-git-send-email-yanok@emcraft.com> <1322498261-20645-14-git-send-email-yanok@emcraft.com> <4ED5E798.2020806@compulab.co.il> Message-ID: <4EE62037.6000801@emcraft.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Igor, thanks for your comments. On 30.11.2011 12:21, Igor Grinberg wrote: >> +#if defined(CONFIG_GENERIC_MMC) && defined(CONFIG_OMAP_HSMMC) && \ >> + !defined(CONFIG_SPL_BUILD) >> +int board_mmc_init(bd_t *bis) >> +{ >> + omap_mmc_init(0); >> + return 0; > > return omap_mmc_init(0); > > I would also define this function ("weak") in some common place, > so we will not need to copy/paste it all over the boards, but > of course, it is not a blocker and I don't request this from you. > Only if you want to... :-) Well, we can use cpu_mmc_init() for this. But what slot(s) should we initialized in this common function? First? All? Regards, Ilya.