* [U-Boot] [PATCH 0/3] i.mx6q: Add the ethernet function support
@ 2011-12-13 13:44 Jason Liu
2011-12-13 13:44 ` [U-Boot] [PATCH 1/3] i.mx: i.mx6q: Add the enet clock function Jason Liu
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Jason Liu @ 2011-12-13 13:44 UTC (permalink / raw)
To: u-boot
This patch add the ethernet function support for i.mx6q/arm2 board.
The patch has been tested ok by: Dirk Behme <dirk.behme@de.bosch.com>
on freescale i.mx6qarm2 board.
Jason Liu (3):
i.mx: i.mx6q: Add the enet clock function
fec: add the i.mx6q enet driver support
i.mx6q: arm2: Add the enet function support
arch/arm/cpu/armv7/mx6/clock.c | 5 ++
board/freescale/mx6qarm2/mx6qarm2.c | 90 +++++++++++++++++++++++++++++++++++
drivers/net/fec_mxc.c | 10 ++++
drivers/net/fec_mxc.h | 7 ++-
include/configs/mx6qarm2.h | 13 ++++-
5 files changed, 122 insertions(+), 3 deletions(-)
--
1.7.4.1
^ permalink raw reply [flat|nested] 9+ messages in thread* [U-Boot] [PATCH 1/3] i.mx: i.mx6q: Add the enet clock function 2011-12-13 13:44 [U-Boot] [PATCH 0/3] i.mx6q: Add the ethernet function support Jason Liu @ 2011-12-13 13:44 ` Jason Liu 2011-12-16 11:21 ` Stefano Babic 2011-12-13 13:44 ` [U-Boot] [PATCH 2/3] fec: add the i.mx6q enet driver support Jason Liu ` (2 subsequent siblings) 3 siblings, 1 reply; 9+ messages in thread From: Jason Liu @ 2011-12-13 13:44 UTC (permalink / raw) To: u-boot Cc: Stefano Babic <sbabic@denx.de> Signed-off-by: Jason Liu <jason.hui@linaro.org> --- arch/arm/cpu/armv7/mx6/clock.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch/arm/cpu/armv7/mx6/clock.c b/arch/arm/cpu/armv7/mx6/clock.c index b143535..fa3a124 100644 --- a/arch/arm/cpu/armv7/mx6/clock.c +++ b/arch/arm/cpu/armv7/mx6/clock.c @@ -285,6 +285,11 @@ u32 imx_get_uartclk(void) return get_uart_clk(); } +u32 imx_get_fecclk(void) +{ + return decode_pll(PLL_ENET, CONFIG_SYS_MX6_HCLK); +} + unsigned int mxc_get_clock(enum mxc_clock clk) { switch (clk) { -- 1.7.4.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 1/3] i.mx: i.mx6q: Add the enet clock function 2011-12-13 13:44 ` [U-Boot] [PATCH 1/3] i.mx: i.mx6q: Add the enet clock function Jason Liu @ 2011-12-16 11:21 ` Stefano Babic 0 siblings, 0 replies; 9+ messages in thread From: Stefano Babic @ 2011-12-16 11:21 UTC (permalink / raw) To: u-boot On 13/12/2011 14:44, Jason Liu wrote: > Cc: Stefano Babic <sbabic@denx.de> > Signed-off-by: Jason Liu <jason.hui@linaro.org> > --- > arch/arm/cpu/armv7/mx6/clock.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/cpu/armv7/mx6/clock.c b/arch/arm/cpu/armv7/mx6/clock.c > index b143535..fa3a124 100644 > --- a/arch/arm/cpu/armv7/mx6/clock.c > +++ b/arch/arm/cpu/armv7/mx6/clock.c > @@ -285,6 +285,11 @@ u32 imx_get_uartclk(void) > return get_uart_clk(); > } > > +u32 imx_get_fecclk(void) > +{ > + return decode_pll(PLL_ENET, CONFIG_SYS_MX6_HCLK); > +} > + > unsigned int mxc_get_clock(enum mxc_clock clk) > { > switch (clk) { Acked-by: Stefano Babic <sbabic@denx.de> Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 2/3] fec: add the i.mx6q enet driver support 2011-12-13 13:44 [U-Boot] [PATCH 0/3] i.mx6q: Add the ethernet function support Jason Liu 2011-12-13 13:44 ` [U-Boot] [PATCH 1/3] i.mx: i.mx6q: Add the enet clock function Jason Liu @ 2011-12-13 13:44 ` Jason Liu 2011-12-16 11:22 ` Stefano Babic 2011-12-13 13:44 ` [U-Boot] [PATCH 3/3] i.mx6q: arm2: Add the enet function support Jason Liu 2011-12-13 14:56 ` [U-Boot] [PATCH 0/3] i.mx6q: Add the ethernet " Dirk Behme 3 siblings, 1 reply; 9+ messages in thread From: Jason Liu @ 2011-12-13 13:44 UTC (permalink / raw) To: u-boot Cc: Stefano Babic <sbabic@denx.de> Signed-off-by: Jason Liu <jason.hui@linaro.org> --- drivers/net/fec_mxc.c | 10 ++++++++++ drivers/net/fec_mxc.h | 7 ++++++- 2 files changed, 16 insertions(+), 1 deletions(-) diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c index b05a4c0..3affda8 100644 --- a/drivers/net/fec_mxc.c +++ b/drivers/net/fec_mxc.c @@ -384,6 +384,14 @@ static int fec_open(struct eth_device *edev) writel(1 << 2, &fec->eth->x_cntrl); fec->rbd_index = 0; +#if defined(CONFIG_MX6Q) + /* Enable ENET HW endian SWAP */ + writel(readl(&fec->eth->ecntrl) | FEC_ECNTRL_DBSWAP, + &fec->eth->ecntrl); + /* Enable ENET store and forward mode */ + writel(readl(&fec->eth->x_wmrk) | FEC_X_WMRK_STRFWD, + &fec->eth->x_wmrk); +#endif /* * Enable FEC-Lite controller */ @@ -485,6 +493,8 @@ static int fec_init(struct eth_device *dev, bd_t* bd) rcntrl = PKTSIZE << FEC_RCNTRL_MAX_FL_SHIFT; if (fec->xcv_type == SEVENWIRE) rcntrl |= FEC_RCNTRL_FCE; + else if (fec->xcv_type == RGMII) + rcntrl |= FEC_RCNTRL_RGMII; else if (fec->xcv_type == RMII) rcntrl |= FEC_RCNTRL_RMII; else /* MII mode */ diff --git a/drivers/net/fec_mxc.h b/drivers/net/fec_mxc.h index 8b26645..39337bf 100644 --- a/drivers/net/fec_mxc.h +++ b/drivers/net/fec_mxc.h @@ -196,6 +196,7 @@ struct ethernet_regs { #define FEC_RCNTRL_PROM 0x00000008 #define FEC_RCNTRL_BC_REJ 0x00000010 #define FEC_RCNTRL_FCE 0x00000020 +#define FEC_RCNTRL_RGMII 0x00000040 #define FEC_RCNTRL_RMII 0x00000100 #define FEC_TCNTRL_GTS 0x00000001 @@ -206,6 +207,9 @@ struct ethernet_regs { #define FEC_ECNTRL_RESET 0x00000001 /* reset the FEC */ #define FEC_ECNTRL_ETHER_EN 0x00000002 /* enable the FEC */ +#define FEC_ECNTRL_DBSWAP 0x00000100 + +#define FEC_X_WMRK_STRFWD 0x00000100 #if defined(CONFIG_MX25) || defined(CONFIG_MX53) /* defines for MIIGSK */ @@ -261,7 +265,8 @@ enum xceiver_type { SEVENWIRE, /* 7-wire */ MII10, /* MII 10Mbps */ MII100, /* MII 100Mbps */ - RMII /* RMII */ + RMII, /* RMII */ + RGMII, /* RGMII */ }; /** -- 1.7.4.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 2/3] fec: add the i.mx6q enet driver support 2011-12-13 13:44 ` [U-Boot] [PATCH 2/3] fec: add the i.mx6q enet driver support Jason Liu @ 2011-12-16 11:22 ` Stefano Babic 0 siblings, 0 replies; 9+ messages in thread From: Stefano Babic @ 2011-12-16 11:22 UTC (permalink / raw) To: u-boot On 13/12/2011 14:44, Jason Liu wrote: > Cc: Stefano Babic <sbabic@denx.de> > Signed-off-by: Jason Liu <jason.hui@linaro.org> > --- > drivers/net/fec_mxc.c | 10 ++++++++++ > drivers/net/fec_mxc.h | 7 ++++++- > 2 files changed, 16 insertions(+), 1 deletions(-) > Acked-by : Stefano Babic <sbabic@denx.de> Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 3/3] i.mx6q: arm2: Add the enet function support 2011-12-13 13:44 [U-Boot] [PATCH 0/3] i.mx6q: Add the ethernet function support Jason Liu 2011-12-13 13:44 ` [U-Boot] [PATCH 1/3] i.mx: i.mx6q: Add the enet clock function Jason Liu 2011-12-13 13:44 ` [U-Boot] [PATCH 2/3] fec: add the i.mx6q enet driver support Jason Liu @ 2011-12-13 13:44 ` Jason Liu 2011-12-16 11:30 ` Stefano Babic 2011-12-13 14:56 ` [U-Boot] [PATCH 0/3] i.mx6q: Add the ethernet " Dirk Behme 3 siblings, 1 reply; 9+ messages in thread From: Jason Liu @ 2011-12-13 13:44 UTC (permalink / raw) To: u-boot This enable the network function on the i.mx6q armadillo2 board(arm2), thus we can use tftp to load image from network. Cc: Stefano Babic <sbabic@denx.de> Signed-off-by: Jason Liu <jason.hui@linaro.org> Tested-by: Dirk Behme <dirk.behme@de.bosch.com> --- board/freescale/mx6qarm2/mx6qarm2.c | 90 +++++++++++++++++++++++++++++++++++ include/configs/mx6qarm2.h | 13 ++++- 2 files changed, 101 insertions(+), 2 deletions(-) diff --git a/board/freescale/mx6qarm2/mx6qarm2.c b/board/freescale/mx6qarm2/mx6qarm2.c index 89e0e76..1df063a 100644 --- a/board/freescale/mx6qarm2/mx6qarm2.c +++ b/board/freescale/mx6qarm2/mx6qarm2.c @@ -29,6 +29,8 @@ #include <asm/gpio.h> #include <mmc.h> #include <fsl_esdhc.h> +#include <miiphy.h> +#include <netdev.h> DECLARE_GLOBAL_DATA_PTR; @@ -40,6 +42,10 @@ DECLARE_GLOBAL_DATA_PTR; PAD_CTL_PUS_47K_UP | PAD_CTL_SPEED_LOW | \ PAD_CTL_DSE_80ohm | PAD_CTL_SRE_FAST | PAD_CTL_HYS) +#define ENET_PAD_CTRL (PAD_CTL_PKE | PAD_CTL_PUE | \ + PAD_CTL_PUS_100K_UP | PAD_CTL_SPEED_MED | \ + PAD_CTL_DSE_40ohm | PAD_CTL_HYS) + int dram_init(void) { gd->ram_size = get_ram_size((void *)PHYS_SDRAM, PHYS_SDRAM_SIZE); @@ -79,11 +85,35 @@ iomux_v3_cfg_t usdhc4_pads[] = { MX6Q_PAD_SD4_DAT7__USDHC4_DAT7 | MUX_PAD_CTRL(USDHC_PAD_CTRL), }; +iomux_v3_cfg_t enet_pads[] = { + MX6Q_PAD_KEY_COL1__ENET_MDIO | MUX_PAD_CTRL(ENET_PAD_CTRL), + MX6Q_PAD_KEY_COL2__ENET_MDC | MUX_PAD_CTRL(ENET_PAD_CTRL), + MX6Q_PAD_RGMII_TXC__ENET_RGMII_TXC | MUX_PAD_CTRL(ENET_PAD_CTRL), + MX6Q_PAD_RGMII_TD0__ENET_RGMII_TD0 | MUX_PAD_CTRL(ENET_PAD_CTRL), + MX6Q_PAD_RGMII_TD1__ENET_RGMII_TD1 | MUX_PAD_CTRL(ENET_PAD_CTRL), + MX6Q_PAD_RGMII_TD2__ENET_RGMII_TD2 | MUX_PAD_CTRL(ENET_PAD_CTRL), + MX6Q_PAD_RGMII_TD3__ENET_RGMII_TD3 | MUX_PAD_CTRL(ENET_PAD_CTRL), + MX6Q_PAD_RGMII_TX_CTL__RGMII_TX_CTL | MUX_PAD_CTRL(ENET_PAD_CTRL), + MX6Q_PAD_ENET_REF_CLK__ENET_TX_CLK | MUX_PAD_CTRL(ENET_PAD_CTRL), + MX6Q_PAD_RGMII_RXC__ENET_RGMII_RXC | MUX_PAD_CTRL(ENET_PAD_CTRL), + MX6Q_PAD_RGMII_RD0__ENET_RGMII_RD0 | MUX_PAD_CTRL(ENET_PAD_CTRL), + MX6Q_PAD_RGMII_RD1__ENET_RGMII_RD1 | MUX_PAD_CTRL(ENET_PAD_CTRL), + MX6Q_PAD_RGMII_RD2__ENET_RGMII_RD2 | MUX_PAD_CTRL(ENET_PAD_CTRL), + MX6Q_PAD_RGMII_RD3__ENET_RGMII_RD3 | MUX_PAD_CTRL(ENET_PAD_CTRL), + MX6Q_PAD_RGMII_RX_CTL__RGMII_RX_CTL | MUX_PAD_CTRL(ENET_PAD_CTRL), +}; + + static void setup_iomux_uart(void) { imx_iomux_v3_setup_multiple_pads(uart4_pads, ARRAY_SIZE(uart4_pads)); } +static void setup_iomux_enet(void) +{ + imx_iomux_v3_setup_multiple_pads(enet_pads, ARRAY_SIZE(enet_pads)); +} + #ifdef CONFIG_FSL_ESDHC struct fsl_esdhc_cfg usdhc_cfg[2] = { {USDHC3_BASE_ADDR, 1}, @@ -132,9 +162,69 @@ int board_mmc_init(bd_t *bis) } #endif +#define MII_MMD_ACCESS_CTRL_REG 0xd +#define MII_MMD_ACCESS_ADDR_DATA_REG 0xe +#define MII_DBG_PORT_REG 0x1d +#define MII_DBG_PORT2_REG 0x1e + +int fecmxc_mii_postcall(int phy) +{ + unsigned short val; + + /* + * Due to the i.MX6Q Armadillo2 board HW design,there is + * no 125Mhz clock input from SOC. In order to use RGMII, + * We need enable AR8031 ouput a 125MHz clk from CLK_25M + */ + miiphy_write("FEC", phy, MII_MMD_ACCESS_CTRL_REG, 0x7); + miiphy_write("FEC", phy, MII_MMD_ACCESS_ADDR_DATA_REG, 0x8016); + miiphy_write("FEC", phy, MII_MMD_ACCESS_CTRL_REG, 0x4007); + miiphy_read("FEC", phy, MII_MMD_ACCESS_ADDR_DATA_REG, &val); + val &= 0xffe3; + val |= 0x18; + miiphy_write("FEC", phy, MII_MMD_ACCESS_ADDR_DATA_REG, val); + + /* For the RGMII phy, we need enable tx clock delay */ + miiphy_write("FEC", phy, 0x1d, 0x5); + miiphy_read("FEC", phy, 0x1e, &val); + val |= 0x0100; + miiphy_write("FEC", phy, 0x1e, val); + + miiphy_write("FEC", phy, MII_BMCR, 0xa100); + + return 0; +} + +int board_eth_init(bd_t *bis) +{ + struct eth_device *dev; + int ret; + + ret = cpu_eth_init(bis); + if (ret) { + printf("FEC MXC: %s:failed\n", __func__); + return ret; + } + + dev = eth_get_dev_by_name("FEC"); + if (!dev) { + printf("FEC MXC: Unable to get FEC device entry\n"); + return -EINVAL; + } + + ret = fecmxc_register_mii_postcall(dev, fecmxc_mii_postcall); + if (ret) { + printf("FEC MXC: Unable to register FEC mii postcall\n"); + return ret; + } + + return 0; +} + int board_early_init_f(void) { setup_iomux_uart(); + setup_iomux_enet(); return 0; } diff --git a/include/configs/mx6qarm2.h b/include/configs/mx6qarm2.h index a7b363d..3a30679 100644 --- a/include/configs/mx6qarm2.h +++ b/include/configs/mx6qarm2.h @@ -56,6 +56,17 @@ #define CONFIG_CMD_FAT #define CONFIG_DOS_PARTITION +#define CONFIG_CMD_PING +#define CONFIG_CMD_DHCP +#define CONFIG_CMD_MII +#define CONFIG_CMD_NET +#define CONFIG_FEC_MXC +#define CONFIG_MII +#define IMX_FEC_BASE ENET_BASE_ADDR +#define CONFIG_FEC_XCV_TYPE RGMII +#define CONFIG_ETHPRIME "FEC" +#define CONFIG_FEC_MXC_PHYADDR 0 + /* allow to overwrite serial and ethaddr */ #define CONFIG_ENV_OVERWRITE #define CONFIG_CONS_INDEX 1 @@ -66,8 +77,6 @@ #include <config_cmd_default.h> #undef CONFIG_CMD_IMLS -#undef CONFIG_CMD_NET -#undef CONFIG_CMD_NFS #define CONFIG_BOOTDELAY 3 -- 1.7.4.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 3/3] i.mx6q: arm2: Add the enet function support 2011-12-13 13:44 ` [U-Boot] [PATCH 3/3] i.mx6q: arm2: Add the enet function support Jason Liu @ 2011-12-16 11:30 ` Stefano Babic 2011-12-16 14:51 ` Liu Hui-R64343 0 siblings, 1 reply; 9+ messages in thread From: Stefano Babic @ 2011-12-16 11:30 UTC (permalink / raw) To: u-boot On 13/12/2011 14:44, Jason Liu wrote: > This enable the network function on the i.mx6q armadillo2 > board(arm2), thus we can use tftp to load image from network. > > Cc: Stefano Babic <sbabic@denx.de> > Signed-off-by: Jason Liu <jason.hui@linaro.org> > Tested-by: Dirk Behme <dirk.behme@de.bosch.com> > --- > board/freescale/mx6qarm2/mx6qarm2.c | 90 +++++++++++++++++++++++++++++++++++ > include/configs/mx6qarm2.h | 13 ++++- > 2 files changed, 101 insertions(+), 2 deletions(-) > Hi Jason, only a couple of minor issues. > + > #ifdef CONFIG_FSL_ESDHC > struct fsl_esdhc_cfg usdhc_cfg[2] = { > {USDHC3_BASE_ADDR, 1}, > @@ -132,9 +162,69 @@ int board_mmc_init(bd_t *bis) > } > #endif > > +#define MII_MMD_ACCESS_CTRL_REG 0xd > +#define MII_MMD_ACCESS_ADDR_DATA_REG 0xe > +#define MII_DBG_PORT_REG 0x1d > +#define MII_DBG_PORT2_REG 0x1e > + > +int fecmxc_mii_postcall(int phy) > +{ > + unsigned short val; > + > + /* > + * Due to the i.MX6Q Armadillo2 board HW design,there is > + * no 125Mhz clock input from SOC. In order to use RGMII, > + * We need enable AR8031 ouput a 125MHz clk from CLK_25M > + */ > + miiphy_write("FEC", phy, MII_MMD_ACCESS_CTRL_REG, 0x7); > + miiphy_write("FEC", phy, MII_MMD_ACCESS_ADDR_DATA_REG, 0x8016); > + miiphy_write("FEC", phy, MII_MMD_ACCESS_CTRL_REG, 0x4007); > + miiphy_read("FEC", phy, MII_MMD_ACCESS_ADDR_DATA_REG, &val); > + val &= 0xffe3; > + val |= 0x18; > + miiphy_write("FEC", phy, MII_MMD_ACCESS_ADDR_DATA_REG, val); > + > + /* For the RGMII phy, we need enable tx clock delay */ > + miiphy_write("FEC", phy, 0x1d, 0x5); You define MII_DBG_PORT_REG, but then you do not use it. > + miiphy_read("FEC", phy, 0x1e, &val); The same here for MII_DBG_PORT2_REG. Can you also defines some constants for the value you are setting (tx clock delay, etc.). > diff --git a/include/configs/mx6qarm2.h b/include/configs/mx6qarm2.h > index a7b363d..3a30679 100644 > --- a/include/configs/mx6qarm2.h > +++ b/include/configs/mx6qarm2.h > @@ -56,6 +56,17 @@ > #define CONFIG_CMD_FAT > #define CONFIG_DOS_PARTITION > > +#define CONFIG_CMD_PING > +#define CONFIG_CMD_DHCP > +#define CONFIG_CMD_MII > +#define CONFIG_CMD_NET > +#define CONFIG_FEC_MXC > +#define CONFIG_MII > +#define IMX_FEC_BASE ENET_BASE_ADDR > +#define CONFIG_FEC_XCV_TYPE RGMII > +#define CONFIG_ETHPRIME "FEC" I have not thought this is needed. I see only one controller. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 3/3] i.mx6q: arm2: Add the enet function support 2011-12-16 11:30 ` Stefano Babic @ 2011-12-16 14:51 ` Liu Hui-R64343 0 siblings, 0 replies; 9+ messages in thread From: Liu Hui-R64343 @ 2011-12-16 14:51 UTC (permalink / raw) To: u-boot >-----Original Message----- From: u-boot-bounces@lists.denx.de [mailto:u-boot-bounces at lists.denx.de] >On Behalf Of Stefano Babic >Sent: Friday, December 16, 2011 7:30 PM >To: Jason Liu >Cc: u-boot at lists.denx.de >Subject: Re: [U-Boot] [PATCH 3/3] i.mx6q: arm2: Add the enet function >support > >On 13/12/2011 14:44, Jason Liu wrote: >> This enable the network function on the i.mx6q armadillo2 board(arm2), >> thus we can use tftp to load image from network. >> >> Cc: Stefano Babic <sbabic@denx.de> >> Signed-off-by: Jason Liu <jason.hui@linaro.org> >> Tested-by: Dirk Behme <dirk.behme@de.bosch.com> >> --- >> board/freescale/mx6qarm2/mx6qarm2.c | 90 >+++++++++++++++++++++++++++++++++++ >> include/configs/mx6qarm2.h | 13 ++++- >> 2 files changed, 101 insertions(+), 2 deletions(-) >> > >Hi Jason, > >only a couple of minor issues. Thanks for the review. > >> + >> #ifdef CONFIG_FSL_ESDHC >> struct fsl_esdhc_cfg usdhc_cfg[2] = { >> {USDHC3_BASE_ADDR, 1}, >> @@ -132,9 +162,69 @@ int board_mmc_init(bd_t *bis) } #endif >> >> +#define MII_MMD_ACCESS_CTRL_REG 0xd >> +#define MII_MMD_ACCESS_ADDR_DATA_REG 0xe >> +#define MII_DBG_PORT_REG 0x1d >> +#define MII_DBG_PORT2_REG 0x1e >> + >> +int fecmxc_mii_postcall(int phy) >> +{ >> + unsigned short val; >> + >> + /* >> + * Due to the i.MX6Q Armadillo2 board HW design,there is >> + * no 125Mhz clock input from SOC. In order to use RGMII, >> + * We need enable AR8031 ouput a 125MHz clk from CLK_25M >> + */ >> + miiphy_write("FEC", phy, MII_MMD_ACCESS_CTRL_REG, 0x7); >> + miiphy_write("FEC", phy, MII_MMD_ACCESS_ADDR_DATA_REG, >0x8016); >> + miiphy_write("FEC", phy, MII_MMD_ACCESS_CTRL_REG, 0x4007); >> + miiphy_read("FEC", phy, MII_MMD_ACCESS_ADDR_DATA_REG, &val); >> + val &= 0xffe3; >> + val |= 0x18; >> + miiphy_write("FEC", phy, MII_MMD_ACCESS_ADDR_DATA_REG, val); >> + >> + /* For the RGMII phy, we need enable tx clock delay */ >> + miiphy_write("FEC", phy, 0x1d, 0x5); > >You define MII_DBG_PORT_REG, but then you do not use it. > >> + miiphy_read("FEC", phy, 0x1e, &val); > >The same here for MII_DBG_PORT2_REG. Can you also defines some >constants for the value you are setting (tx clock delay, etc.). Yeah, thanks for it. I will use MII_DBG_PORT_REG and MII_DBG_PORT2_REG. > >> diff --git a/include/configs/mx6qarm2.h b/include/configs/mx6qarm2.h >> index a7b363d..3a30679 100644 >> --- a/include/configs/mx6qarm2.h >> +++ b/include/configs/mx6qarm2.h >> @@ -56,6 +56,17 @@ >> #define CONFIG_CMD_FAT >> #define CONFIG_DOS_PARTITION >> >> +#define CONFIG_CMD_PING >> +#define CONFIG_CMD_DHCP >> +#define CONFIG_CMD_MII >> +#define CONFIG_CMD_NET >> +#define CONFIG_FEC_MXC >> +#define CONFIG_MII >> +#define IMX_FEC_BASE ENET_BASE_ADDR >> +#define CONFIG_FEC_XCV_TYPE RGMII >> +#define CONFIG_ETHPRIME "FEC" > >I have not thought this is needed. I see only one controller. Yes, I think we can remove it. Best regards, Jason Liu > >Best regards, >Stefano Babic > >-- >================================================================= >==== >DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel >HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany >Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de >================================================================= >==== >_______________________________________________ >U-Boot mailing list >U-Boot at lists.denx.de >http://lists.denx.de/mailman/listinfo/u-boot ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH 0/3] i.mx6q: Add the ethernet function support 2011-12-13 13:44 [U-Boot] [PATCH 0/3] i.mx6q: Add the ethernet function support Jason Liu ` (2 preceding siblings ...) 2011-12-13 13:44 ` [U-Boot] [PATCH 3/3] i.mx6q: arm2: Add the enet function support Jason Liu @ 2011-12-13 14:56 ` Dirk Behme 3 siblings, 0 replies; 9+ messages in thread From: Dirk Behme @ 2011-12-13 14:56 UTC (permalink / raw) To: u-boot On 13.12.2011 14:44, Jason Liu wrote: > This patch add the ethernet function support for i.mx6q/arm2 board. > > The patch has been tested ok by: Dirk Behme <dirk.behme@de.bosch.com> > on freescale i.mx6qarm2 board. > > Jason Liu (3): > i.mx: i.mx6q: Add the enet clock function > fec: add the i.mx6q enet driver support > i.mx6q: arm2: Add the enet function support > > arch/arm/cpu/armv7/mx6/clock.c | 5 ++ > board/freescale/mx6qarm2/mx6qarm2.c | 90 +++++++++++++++++++++++++++++++++++ > drivers/net/fec_mxc.c | 10 ++++ > drivers/net/fec_mxc.h | 7 ++- > include/configs/mx6qarm2.h | 13 ++++- > 5 files changed, 122 insertions(+), 3 deletions(-) Whole series: Tested-by: Dirk Behme <dirk.behme@de.bosch.com> Thanks Dirk ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2011-12-16 14:51 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-12-13 13:44 [U-Boot] [PATCH 0/3] i.mx6q: Add the ethernet function support Jason Liu 2011-12-13 13:44 ` [U-Boot] [PATCH 1/3] i.mx: i.mx6q: Add the enet clock function Jason Liu 2011-12-16 11:21 ` Stefano Babic 2011-12-13 13:44 ` [U-Boot] [PATCH 2/3] fec: add the i.mx6q enet driver support Jason Liu 2011-12-16 11:22 ` Stefano Babic 2011-12-13 13:44 ` [U-Boot] [PATCH 3/3] i.mx6q: arm2: Add the enet function support Jason Liu 2011-12-16 11:30 ` Stefano Babic 2011-12-16 14:51 ` Liu Hui-R64343 2011-12-13 14:56 ` [U-Boot] [PATCH 0/3] i.mx6q: Add the ethernet " Dirk Behme
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox