From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Tue, 13 Dec 2011 12:45:26 -0600 Subject: [U-Boot] [PATCH V3] nand_spl_simple: store ecc data on the stack In-Reply-To: References: <1323624146-8402-1-git-send-email-sbabic@denx.de> <1323798615-23154-1-git-send-email-sbabic@denx.de> <20111213181839.B29348223E@gemini.denx.de> Message-ID: <4EE79D46.7000302@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 12/13/2011 12:33 PM, Tom Rini wrote: > So, we have various characteristics of the NAND chip that need to be > described for SPL. Today we do CONFIG_SYS_NAND... but they're > unchanged in every implementation and are calculated from other > per-board values. So to avoid duplication in each config file, we > drop them from there and use them only locally #define calculate them > in the file that needs them. Since they're still system specific > values, I had suggested calling them SYS_... but I wasn't sure what > the right namespace is. I had a recollection that using CONFIG_ > outside of config files was a bad idea. These symbols are not in a header file -- how about just plain ECCSTEPS and ECCTOTAL? -Scott