From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ilya Yanok <yanok@emcraft.com>
Date: Tue, 13 Dec 2011 22:57:32 +0400
Subject: [U-Boot] [PATCH V4 2/2] mcx: support for HTKW mcx board
In-Reply-To: <CA+M6bXmG8DGuWz2mLYQXXHDrfc_eP2Vqb+cVj1WNcv9hcXccTg@mail.gmail.com>
References: <1323731713-5460-1-git-send-email-yanok@emcraft.com>	<1323731713-5460-3-git-send-email-yanok@emcraft.com>
	<CA+M6bXmG8DGuWz2mLYQXXHDrfc_eP2Vqb+cVj1WNcv9hcXccTg@mail.gmail.com>
Message-ID: <4EE7A01C.7070508@emcraft.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Tom,

On 13.12.2011 22:52, Tom Rini wrote:
> On Mon, Dec 12, 2011 at 4:15 PM, Ilya Yanok <yanok@emcraft.com> wrote:
>> This patch adds support for the HTKW mcx AM3517-based board.
>> Serial, Ethernet, NAND, MMC, RTC, EHCI USB host and both
>> NAND and MMC SPLs are supported.
>>
>> Requires updated mach-types file.
> 
> Just define the MACH_ID locally for now so it builds still please.

Ok, will do.

> Also, some problems:
> 
>> +#if defined(CONFIG_OMAP_HSMMC) && !defined(CONFIG_SPL_BUILD)
>> +int board_mmc_init(bd_t *bis)
>> +{
>> +       omap_mmc_init(0);
>> +       return 0;
>> +}
>> +#endif
> 
> That should just be return omap_mmc_init(0);

Surely. I've been told about this one already but forgot to fix it. Sorry.

> [snip to config file]
>> +#define CONFIG_SYS_TEXT_BASE           0x80008000
> [snip]
>> +#define CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR        0x300 /* address 0x60000 */
>> +#define CONFIG_SYS_MMC_SD_FAT_BOOT_PARTITION   1
>> +#define CONFIG_SPL_FAT_LOAD_PAYLOAD_NAME       "u-boot.img"
> 
> You're able to have CONFIG_SYS_TEXT_BASE that low and not have the
> corruption problem devkit8000 had?

Hm. What corruption problem?

>> +#define CONFIG_SYS_NAND_U_BOOT_SIZE    0x60000
> 
> IIRC you don't need this define since this SPL says you write
> u-boot.img to NAND not u-boot.bin

Right.

Regards, Ilya.