From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3] nand_spl_simple: store ecc data on the stack
Date: Tue, 13 Dec 2011 20:26:41 +0100 [thread overview]
Message-ID: <4EE7A6F1.9080309@denx.de> (raw)
In-Reply-To: <4EE79D46.7000302@freescale.com>
On 13/12/2011 19:45, Scott Wood wrote:
> On 12/13/2011 12:33 PM, Tom Rini wrote:
>> So, we have various characteristics of the NAND chip that need to be
>> described for SPL. Today we do CONFIG_SYS_NAND... but they're
>> unchanged in every implementation and are calculated from other
>> per-board values. So to avoid duplication in each config file, we
>> drop them from there and use them only locally #define calculate them
>> in the file that needs them. Since they're still system specific
>> values, I had suggested calling them SYS_... but I wasn't sure what
>> the right namespace is. I had a recollection that using CONFIG_
>> outside of config files was a bad idea.
>
> These symbols are not in a header file -- how about just plain ECCSTEPS
> and ECCTOTAL?
Ok, agree - done in V4.
Regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2011-12-13 19:26 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-11 17:22 [U-Boot] [PATCH] nand_spl_simple: store ecc data on the stack Stefano Babic
2011-12-12 0:08 ` Ilya Yanok
2011-12-13 10:33 ` Stefano Babic
2011-12-13 11:30 ` [U-Boot] [PATCH V2] " Stefano Babic
2011-12-13 15:58 ` Tom Rini
2011-12-13 17:31 ` Stefano Babic
2011-12-13 17:50 ` [U-Boot] [PATCH V3] " Stefano Babic
2011-12-13 18:04 ` Tom Rini
2011-12-13 18:18 ` Wolfgang Denk
2011-12-13 18:33 ` Tom Rini
2011-12-13 18:45 ` Scott Wood
2011-12-13 18:54 ` Tom Rini
2011-12-13 19:26 ` Stefano Babic [this message]
2011-12-13 18:48 ` stefano babic
2011-12-13 18:52 ` Scott Wood
2011-12-13 18:54 ` Tom Rini
2011-12-13 18:47 ` Scott Wood
2011-12-13 19:33 ` [U-Boot] [PATCH V4] " Stefano Babic
2011-12-13 21:30 ` Tom Rini
2011-12-14 8:22 ` Simon Schwarz
2011-12-14 8:49 ` Stefano Babic
[not found] ` <4EE9B7F8.5060305@gmail.com>
2011-12-15 9:53 ` Stefano Babic
2012-01-10 23:01 ` Scott Wood
2012-01-10 23:24 ` Tom Rini
2012-02-03 20:17 ` Albert ARIBAUD
2012-02-03 21:47 ` Tom Rini
2011-12-15 9:55 ` [U-Boot] [PATCH V5] " Stefano Babic
2011-12-15 22:18 ` Scott Wood
2012-01-05 23:12 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE7A6F1.9080309@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox