From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Tue, 13 Dec 2011 20:26:41 +0100 Subject: [U-Boot] [PATCH V3] nand_spl_simple: store ecc data on the stack In-Reply-To: <4EE79D46.7000302@freescale.com> References: <1323624146-8402-1-git-send-email-sbabic@denx.de> <1323798615-23154-1-git-send-email-sbabic@denx.de> <20111213181839.B29348223E@gemini.denx.de> <4EE79D46.7000302@freescale.com> Message-ID: <4EE7A6F1.9080309@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 13/12/2011 19:45, Scott Wood wrote: > On 12/13/2011 12:33 PM, Tom Rini wrote: >> So, we have various characteristics of the NAND chip that need to be >> described for SPL. Today we do CONFIG_SYS_NAND... but they're >> unchanged in every implementation and are calculated from other >> per-board values. So to avoid duplication in each config file, we >> drop them from there and use them only locally #define calculate them >> in the file that needs them. Since they're still system specific >> values, I had suggested calling them SYS_... but I wasn't sure what >> the right namespace is. I had a recollection that using CONFIG_ >> outside of config files was a bad idea. > > These symbols are not in a header file -- how about just plain ECCSTEPS > and ECCTOTAL? Ok, agree - done in V4. Regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================