public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V4] nand_spl_simple: store ecc data on the stack
Date: Wed, 14 Dec 2011 09:49:41 +0100	[thread overview]
Message-ID: <4EE86325.1010807@denx.de> (raw)
In-Reply-To: <4EE85CC6.5060300@gmail.com>

On 14/12/2011 09:22, Simon Schwarz wrote:
> On 12/13/2011 08:33 PM, Stefano Babic wrote:
>> Currently nand_spl_simple puts it's temp data at 0x10000 offset in SDRAM
>> which is likely to contain already loaded data.
>> The patch saves the oob data and the ecc on the stack replacing
>> the fixed address in RAM.
>>
>> Signed-off-by: Stefano Babic<sbabic@denx.de>
>> CC: Ilya Yanok<yanok@emcraft.com>
>> CC: Scott Wood<scottwood@freescale.com>
>> CC: Tom Rini<tom.rini@gmail.com>
>> CC: Simon Schwarz<simonschwarzcor@googlemail.com>
>> CC: Wolfgang Denk<wd@denx.de>
>> ---
>> V4:
>>   - Drop SYS_ from local defines (Wolfgang Denk, Scott Wood)
>>   - drop parenthesis around defines (Scott Wood)
>>
>> V3:
>>   - use local defines for CONFIG_SYS_NAND_ECCSTEPS and
>>     CONFIG_SYS_NAND_ECCTOTAL (Tom Rini)
>>   - drop CONFIG_SYS_NAND_ECCSTEPS from board config files
>>
>> V2:
>>   - CONFIG_SYS_NAND_ECCTOTAL can always be computed (Ilya Yanok)
>>   - drop all CONFIG_SYS_NAND_ECCTOTAL in arm boards using nand_simple.c
>>
> [SNIP]
> 
> Hi Stefano,
> 
> on which repo is this patch based? I tried to test it on u-boot but the
> patch does not apply.

Because I thought that the patch will be merged by Tom, I rebased the
patch on u-boot-ti. This is also because there is Ilya's patch:

	nand_spl_simple: add support for software ECC

that modifies the same file. The patch can be applied flawlessy on top
of u-boot-ti, I have checked now again.

For testing I have then applied your SPL Linux patches, and tried to
boot linux, as I know there is a conflict with the ECC area.

Tom, it is surely better (I forget to mention) that you merge the patch
into u-boot-ti, because you have already merged Ilya's patch.

Regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2011-12-14  8:49 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-11 17:22 [U-Boot] [PATCH] nand_spl_simple: store ecc data on the stack Stefano Babic
2011-12-12  0:08 ` Ilya Yanok
2011-12-13 10:33   ` Stefano Babic
2011-12-13 11:30 ` [U-Boot] [PATCH V2] " Stefano Babic
2011-12-13 15:58   ` Tom Rini
2011-12-13 17:31     ` Stefano Babic
2011-12-13 17:50 ` [U-Boot] [PATCH V3] " Stefano Babic
2011-12-13 18:04   ` Tom Rini
2011-12-13 18:18     ` Wolfgang Denk
2011-12-13 18:33       ` Tom Rini
2011-12-13 18:45         ` Scott Wood
2011-12-13 18:54           ` Tom Rini
2011-12-13 19:26           ` Stefano Babic
2011-12-13 18:48       ` stefano babic
2011-12-13 18:52     ` Scott Wood
2011-12-13 18:54       ` Tom Rini
2011-12-13 18:47   ` Scott Wood
2011-12-13 19:33 ` [U-Boot] [PATCH V4] " Stefano Babic
2011-12-13 21:30   ` Tom Rini
2011-12-14  8:22   ` Simon Schwarz
2011-12-14  8:49     ` Stefano Babic [this message]
     [not found]       ` <4EE9B7F8.5060305@gmail.com>
2011-12-15  9:53         ` Stefano Babic
2012-01-10 23:01   ` Scott Wood
2012-01-10 23:24     ` Tom Rini
2012-02-03 20:17       ` Albert ARIBAUD
2012-02-03 21:47         ` Tom Rini
2011-12-15  9:55 ` [U-Boot] [PATCH V5] " Stefano Babic
2011-12-15 22:18   ` Scott Wood
2012-01-05 23:12   ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EE86325.1010807@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox