[U-Boot] [PATCH] add initial support for bluegiga apx4devkit

[Veli-Pekka Peltola <veli-pekka.peltola@bluegiga.com>]

On 12/14/2011 05:04 PM, Stefano Babic wrote:
>>>> +void imx_get_mac_from_fuse(char *mac)
>>>> +{
>>>> +    memset(mac, 0, 6);
>>>> +}
>>>
>>> This is wrong, and surely you do not get the address from fuses.
>>
>> What is correct way to get ethernet mac from environment instead of
>> fuses? FEC driver seems to call imx_get_mac_from_fuse always. Should it
>> be changed to use a new configuration option? Or should we try to read
>> mac from fuses which are zeros and then fall back to environment?
>
> I have supposed that new Freescale's SOCs are always delivered with a
> valid MAC address in the fuses. Some IMX SOCs have no fuse at all, and
> the MAC address is only taken from the environment, such as the MX35.

At least our i.MX28 SoCs doesn't have any fuses preprogrammed. MX28EVK 
seems to have CUST0 and CUST1 preprogrammed.

> I see here a couple of points. First at all, imx_get_mac_from_fuse
> should be factorized between your board and m28evk. Maybe we need some
> CONFIG_ to add the vendor part, but reading from fuse itself can be
> shared code. and if the values read are all zeroes, we have the fallback
> to the environment ethaddr variable.

I will try to do some factorization.

Our product is more like an OEM thing so we try to avoid programming any 
fuses as our customers might want to do that with their own mac address.

--
Veli-Pekka Peltola