[U-Boot] [PATCH] arm, davinci: Fix build warnings for cam_enc_4xx

[U-Boot] [PATCH] arm, davinci: Fix build warnings for cam_enc_4xx

[Christian Riesch]

This patch fixes a build warning for the cam_enc_4xx board introduced by
commit d6ec0c0dfc70447cf615ae80a952da81f73f16b4:

spl.c:35:13: warning: 'gdata' defined but not used
spl.c:36:13: warning: 'bdata' defined but not used

Signed-off-by: Christian Riesch <christian.riesch@omicron.at>
Cc: Tom Rini <trini@ti.com>
Cc: Heiko Schocher <hs@denx.de>
---

Hi,
this patch applies on top of the ti/next branch.
Thanks, Christian

 arch/arm/cpu/arm926ejs/davinci/spl.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm/cpu/arm926ejs/davinci/spl.c b/arch/arm/cpu/arm926ejs/davinci/spl.c
index 20f798e..f475f9b 100644
--- a/arch/arm/cpu/arm926ejs/davinci/spl.c
+++ b/arch/arm/cpu/arm926ejs/davinci/spl.c
@@ -29,13 +29,14 @@
 #include <malloc.h>
 #include <spi_flash.h>
 
-DECLARE_GLOBAL_DATA_PTR;
+#ifdef CONFIG_SPL_LIBCOMMON_SUPPORT
 
+DECLARE_GLOBAL_DATA_PTR;
 /* Define global data structure pointer to it*/
 static gd_t gdata __attribute__ ((section(".data")));
 static bd_t bdata __attribute__ ((section(".data")));
 
-#ifndef CONFIG_SPL_LIBCOMMON_SUPPORT
+#else
 
 void puts(const char *str)
 {
-- 
1.7.0.4

[U-Boot] [PATCH] arm, davinci: Fix build warnings for cam_enc_4xx

[Tom Rini]

On 12/14/2011 01:54 AM, Christian Riesch wrote:
> This patch fixes a build warning for the cam_enc_4xx board introduced by
> commit d6ec0c0dfc70447cf615ae80a952da81f73f16b4:
> 
> spl.c:35:13: warning: 'gdata' defined but not used
> spl.c:36:13: warning: 'bdata' defined but not used
> 
> Signed-off-by: Christian Riesch <christian.riesch@omicron.at>
> Cc: Tom Rini <trini@ti.com>
> Cc: Heiko Schocher <hs@denx.de>

Applied to u-boot-ti/next, thanks!

-- 
Tom

[U-Boot] [PATCH] arm, davinci: Fix build warnings for cam_enc_4xx

[Heiko Schocher]

Hello Christian,

Christian Riesch wrote:
> This patch fixes a build warning for the cam_enc_4xx board introduced by
> commit d6ec0c0dfc70447cf615ae80a952da81f73f16b4:
> 
> spl.c:35:13: warning: 'gdata' defined but not used
> spl.c:36:13: warning: 'bdata' defined but not used
> 
> Signed-off-by: Christian Riesch <christian.riesch@omicron.at>
> Cc: Tom Rini <trini@ti.com>
> Cc: Heiko Schocher <hs@denx.de>
> ---
> 
> Hi,
> this patch applies on top of the ti/next branch.
> Thanks, Christian

Tested on the cam_enc_4x board, thanks!

Also too late, but:

Acked-by: Heiko Schocher <hs@denx.de>
Tested-by: Heiko Schocher <hs@denx.de>

@Tom: Could you please wait 1-2 days before applying patches, so
people could test them ;-) Thanks

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[U-Boot] [PATCH] arm, davinci: Fix build warnings for cam_enc_4xx

[Tom Rini]

On Wed, Dec 14, 2011 at 11:22 PM, Heiko Schocher <hs@denx.de> wrote:
> Hello Christian,
>
> Christian Riesch wrote:
>> This patch fixes a build warning for the cam_enc_4xx board introduced by
>> commit d6ec0c0dfc70447cf615ae80a952da81f73f16b4:
>>
>> spl.c:35:13: warning: 'gdata' defined but not used
>> spl.c:36:13: warning: 'bdata' defined but not used
>>
>> Signed-off-by: Christian Riesch <christian.riesch@omicron.at>
>> Cc: Tom Rini <trini@ti.com>
>> Cc: Heiko Schocher <hs@denx.de>
>> ---
>>
>> Hi,
>> this patch applies on top of the ti/next branch.
>> Thanks, Christian
>
> Tested on the cam_enc_4x board, thanks!
>
> Also too late, but:
>
> Acked-by: Heiko Schocher <hs@denx.de>
> Tested-by: Heiko Schocher <hs@denx.de>
>
> @Tom: Could you please wait 1-2 days before applying patches, so
> people could test them ;-) Thanks

As a general rule, yes, I am trying to make sure I do.  But for things
like warning fixes or things I can verify by inspection, I might pick
them up quicker :)

-- 
Tom