public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v6 4/6] arm, da850evm: Add an SPL for SPI boot
Date: Wed, 14 Dec 2011 15:09:10 -0700	[thread overview]
Message-ID: <4EE91E86.60705@ti.com> (raw)
In-Reply-To: <CABkLObp0HGh_VO4pfS5yPPwtwoDkqAkTxwdpOtBAp6GMd9Lmxg@mail.gmail.com>

On 12/14/2011 02:49 PM, Christian Riesch wrote:
> Hi Tom,
> thanks for your reply.
> 
> On Wed, Dec 14, 2011 at 8:15 PM, Tom Rini <trini@ti.com
> <mailto:trini@ti.com>> wrote:
>> On 12/14/2011 12:09 PM, Christian Riesch wrote:
>>> I applied the changes that I did in include/configs/da850evm.h before to
>>> da850_am18xxevm.h as well. I expected this to work on my board since the
>>> board I used to test the SPI flash SPL patchset for the da850evm was
>>> actually an AM1808 experimenter's kit.
>>>
>>> Now my SPL reports:
>>>
>>> SF: Unsupported manufacturer 20
>>> failed.
>>>
>>> Manufacturer 0x20 seems to be ST and the main difference between
>>> da850evm.h and da850_am18xxevm.h is the missing #define
>>> CONFIG_SPI_FLASH_STMICRO in da850_am18xxevm.h.
>>>
>>> So my question is: Which boards are supported by da850_am18xxevm.h? I
>>> thought that I probably have an old revision of the board, but I
>>> couldn't find anything regarding SPI flash in LogicPD's PCNs.
>>
>> So, the da850evm is for the OMAP-L138 and da850_am18xxevm is for the
>> AM18xx EVM.  However, the config split was done, I believe, but folks on
>> the L138 side and might not have been tried fully on the am1808.  So
>> since you've got the AM1808 and can test it there, lets add the missing
>> SPI_FLASH define too.  I think my coworker that did a quick non-SPL
>> check of the code the other week also noted SPI wasn't supported.
> 
> Ok, I can do that.
> 
> But then I wonder why a separate .h file for the AM18xx EVM was
> introduced. My AM18xx EVM works just fine with the da850evm.h
> configuration that's currently in mainline u-boot.
> 
> I did a diff between the two:
[snip explanation of how little is actually different]

I agree.  It's on my list to unpack and get my am18xx EVM setup and see
if perhaps we can't just use boards.cfg to build for L138 or AM1808.

-- 
Tom

  reply	other threads:[~2011-12-14 22:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-09 19:47 [U-Boot] [PATCH v6 0/6] Add an SPL to boot the da850evm from SPI Christian Riesch
2011-12-09 19:47 ` [U-Boot] [PATCH v6 1/6] spl: display_options.o is required for SPI flash support in SPL Christian Riesch
2011-12-09 19:47 ` [U-Boot] [PATCH v6 2/6] sf: Add spi_boot() to allow booting from SPI flash in an SPL Christian Riesch
2011-12-09 19:47 ` [U-Boot] [PATCH v6 3/6] arm, davinci: Add SPL support for DA850 SoCs Christian Riesch
2011-12-09 19:47 ` [U-Boot] [PATCH v6 4/6] arm, da850evm: Add an SPL for SPI boot Christian Riesch
2011-12-14  6:33   ` Christian Riesch
2011-12-14 14:09     ` Tom Rini
2011-12-14 19:09       ` Christian Riesch
2011-12-14 19:15         ` Tom Rini
2011-12-14 21:49           ` Christian Riesch
2011-12-14 22:09             ` Tom Rini [this message]
2011-12-09 19:47 ` [U-Boot] [PATCH v6 5/6] mkimage: Fix variable length header support Christian Riesch
2011-12-09 19:47 ` [U-Boot] [PATCH v6 6/6] arm, davinci: Add support for generating AIS images to the Makefile Christian Riesch
2011-12-13 18:42 ` [U-Boot] [PATCH v6 0/6] Add an SPL to boot the da850evm from SPI Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EE91E86.60705@ti.com \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox