[U-Boot] [PATCH v4] ARMV7: Add support For Logic OMAP35x/DM37x modules

Peter Barada
2011-12-19T15:44:56Z

On 12/19/2011 02:37 AM, Igor Grinberg wrote:
> Hi Peter,
>
> Thanks for fixing all the issues pointed.
> I have one last question (sorry for not seeing it earlier) and one neat below.
>
> On 12/18/11 19:25, Peter Barada wrote:
>> This patch adds basic support for OMAP35x/DM37x SOM LV/Torpedo
>> reference boards. It assumes U-boot is loaded to SDRAM with the
>> help of another small bootloader (x-load) running from SRAM.
>>
>> Signed-off-by: Peter Barada <peter.barada@logicpd.com>
>> Cc: Tom Rini <tom.rini@gmail.com>
>> Cc: Igor Grinberg <grinberg@compulab.co.il>
>> Cc: Wolfgang Denk <wd@denx.de>
>> ---
[ ... ]
>
>
> The TRM says that the initial state of pins is the safe mode (M7).
> Also not every pin has this state by definition.
> So the question is, wouldn't it be better to remove those lines
> that setup the safe mode, or is there a purpose, which I don't see?
> Removing those lines will make the file/patch much shorter.
Back when we first started with u-boot on these boards, it was loaded
from another bootloader that did its own pinmux setup and this was how I
put all the pins back to a known state. Moving to SPL/u-boot will
preclude having to tweak all the pins.

I'll trim the pinmux setup back to only those pins that are different
than their reset values (or those that need PTD/EN pulldowns to minimise
power consumption when the kernel goes into suspend).

>> +/* DDR - I use Micron DDR */
>> +#define CONFIG_OMAP3_MICRON_DDR
> You forgot to remove that one - it is not used anymore...
Done...

> [...]
>
> --
> Regards,
> Igor.

--
Peter Barada
peter.barada at logicpd.com