[U-Boot] [PATCH v2 3/3] mx28evk: Add initial support for MX28EVK board

[Stefano Babic <sbabic@denx.de>]

On 15/12/2011 17:21, Fabio Estevam wrote:
> Add initial support for Freescale MX28EVK board.
> 
> Tested boot via SD card and by loading a kernel via TFTP through
> the FEC interface.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> - For correct operation of saving environment variables into the SD card,
> the following patch is needed:
> http://lists.denx.de/pipermail/u-boot/2011-November/111448.html
> 
> Changes since v1:
> - Read the MAC from fuses
> - Use tabs instead of space in u-boot.bd
> - Use puts instead of print
> - Factor out mac reading function
> - Factor out ddr size calculation function
> - Use GENERATED_GBL_DATA_SIZE
> - Protect CONFIG_ENV_IS_IN_MMC
> 
>  MAINTAINERS                                |    1 +
>  arch/arm/cpu/arm926ejs/mx28/mx28.c         |   56 +++++++++
>  arch/arm/include/asm/arch-mx28/sys_proto.h |    3 +
>  board/denx/m28evk/m28evk.c                 |   56 ---------
>  board/freescale/common/sdhc_boot.c         |    2 +
>  board/freescale/mx28evk/Makefile           |   49 ++++++++
>  board/freescale/mx28evk/iomux.c            |  138 ++++++++++++++++++++++
>  board/freescale/mx28evk/mx28evk.c          |  164 ++++++++++++++++++++++++++
>  board/freescale/mx28evk/u-boot.bd          |   14 +++
>  boards.cfg                                 |    1 +
>  include/configs/mx28evk.h                  |  172 ++++++++++++++++++++++++++++
>  11 files changed, 600 insertions(+), 56 deletions(-)
>  create mode 100644 board/freescale/mx28evk/Makefile
>  create mode 100644 board/freescale/mx28evk/iomux.c
>  create mode 100644 board/freescale/mx28evk/mx28evk.c
>  create mode 100644 board/freescale/mx28evk/u-boot.bd
>  create mode 100644 include/configs/mx28evk.h
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index a56ca10..72e1089 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -639,6 +639,7 @@ Kristoffer Ericson <kristoffer.ericson@gmail.com>
>  Fabio Estevam <fabio.estevam@freescale.com>
>  
>  	mx25pdk		i.MX25
> +	mx28evk		i.MX28
>  	mx31pdk		i.MX31
>  	mx53ard		i.MX53
>  	mx53smd		i.MX53
> diff --git a/arch/arm/cpu/arm926ejs/mx28/mx28.c b/arch/arm/cpu/arm926ejs/mx28/mx28.c
> index 088c019..e15b158 100644
> --- a/arch/arm/cpu/arm926ejs/mx28/mx28.c
> +++ b/arch/arm/cpu/arm926ejs/mx28/mx28.c
> @@ -214,6 +214,62 @@ int cpu_eth_init(bd_t *bis)
>  }
>  #endif
>  
> +#ifdef	CONFIG_MX28_FEC_MAC_IN_OCOTP
> +
> +#define	MXS_OCOTP_MAX_TIMEOUT	1000000
> +void imx_get_mac_from_fuse(char *mac)
> +{
> +	struct mx28_ocotp_regs *ocotp_regs =
> +		(struct mx28_ocotp_regs *)MXS_OCOTP_BASE;
> +	uint32_t data;

Wait...this patch conflict with your first patch of your patchset, where
you have already move this code in a common place. Anything wrong with
your patchset ?

Regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================