From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Babic <sbabic@denx.de>
Date: Thu, 15 Dec 2011 18:53:14 +0100
Subject: [U-Boot] [PATCH v3 1/3] mx28: Let imx_get_mac_from_fuse be
 common for mx28
In-Reply-To: <1323966889-30034-1-git-send-email-fabio.estevam@freescale.com>
References: <1323966067-28333-1-git-send-email-fabio.estevam@freescale.com>
	<1323966889-30034-1-git-send-email-fabio.estevam@freescale.com>
Message-ID: <4EEA340A.3080802@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 15/12/2011 17:34, Fabio Estevam wrote:
> Let imx_get_mac_from_fuse function be a common function, so that other
> mx28 boards can reuse it.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---

Hi Fabio,

> +	if (mx28_wait_mask_clr(&ocotp_regs->hw_ocotp_ctrl_reg, OCOTP_CTRL_BUSY,
> +				MXS_OCOTP_MAX_TIMEOUT)) {
> +		puts("MXS FEC: Can't get MAC from OCOTP\n");
> +		return;
> +	}
> +
> +	data = readl(&ocotp_regs->hw_ocotp_cust0);
> +
> +	mac[0] = 0x00;
> +	mac[1] = 0x04;

Maybe it is worth to add a comment to explain that the magic numbers
0x00 - 0x04 are the Freescale's vendor prefix.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================