From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Fri, 16 Dec 2011 09:57:23 +0100 Subject: [U-Boot] [PATCH v5 2/3] mx28: Let dram_init be common for mx28 In-Reply-To: <1323986861-21808-2-git-send-email-festevam@gmail.com> References: <1323966067-28333-1-git-send-email-fabio.estevam@freescale.com> <1323986861-21808-2-git-send-email-festevam@gmail.com> Message-ID: <4EEB07F3.1080601@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 15/12/2011 23:07, Fabio Estevam wrote: > Let dram_init function be a common function, so that other mx28 boards > can reuse it. > > Signed-off-by: Fabio Estevam > --- > -int board_init(void) > +int dram_init(void) > { > - /* Adress of boot parameters */ > - gd->bd->bi_boot_params = PHYS_SDRAM_1 + 0x100; > - > + mx28_dram_init(); > return 0; Why not simply return mx28_dram_init() ? We do not drop the return code if mx28_dram_init will be changed. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================