From: Holger Brunck <holger.brunck@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] km/common: add toolchain variable
Date: Mon, 19 Dec 2011 09:07:47 +0100 [thread overview]
Message-ID: <4EEEF0D3.5040302@keymile.com> (raw)
In-Reply-To: <20111217204908.102C21ECC61@gemini.denx.de>
Hi Wolfgang,
On 12/17/2011 09:49 PM, Wolfgang Denk wrote:
> In message <1323879110-8404-1-git-send-email-holger.brunck@keymile.com> you wrote:
>> Add a variable "toolchain" and configure the rootpath
>> for the nfsargs with this variable.
>>
>> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
>> cc: Wolfgang Denk <wd@denx.de>
>> ---
>> board/keymile/scripts/README | 2 +-
>> board/keymile/scripts/develop-common.txt | 3 ++-
>> 2 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/board/keymile/scripts/README b/board/keymile/scripts/README
>> index 7fbcf74..dd935b2 100644
>> --- a/board/keymile/scripts/README
>> +++ b/board/keymile/scripts/README
>> @@ -7,7 +7,7 @@ default environment must be parsed:
>> run develop : setup environment to configure for rootfs via nfs
>> run ramfs : setup environment to configure for rootfs in ram
>>
>> -Last change: 20.05.2011
>> +Last change: 24.11.2011
>
> Does this really make any sense? Which date are you recording here/
> When you (think) you last edited the file? When you applied the patch
> to your local tree? When you submitted it for mainline? When it
> actually got applied?
>
What I want to record is to track the version of the scripts and this makes
sense for me. In the end the scripts are copied into /tftpboot on each
developers machine and is therefore not under git control. It is an easy
indication wether the scripts are uptodate or not, without starting a diff tool
and compare them with the latest git tree. Inside the git tree the information
is useless, I agree.
> I recommend to get rid of this, and rather use git revision
> information instead.
>
I would like to keep this, because git does not easily help here.
Best regards
Holger
next prev parent reply other threads:[~2011-12-19 8:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 16:11 [U-Boot] [PATCH] km/common: add toolchain variable Holger Brunck
2011-12-17 20:49 ` Wolfgang Denk
2011-12-19 8:07 ` Holger Brunck [this message]
2011-12-19 8:57 ` Wolfgang Denk
2011-12-19 10:37 ` Holger Brunck
2011-12-19 11:33 ` Wolfgang Denk
2011-12-19 12:58 ` Holger Brunck
2011-12-19 15:30 ` Wolfgang Denk
2011-12-20 22:44 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEEF0D3.5040302@keymile.com \
--to=holger.brunck@keymile.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox