From mboxrd@z Thu Jan 1 00:00:00 1970 From: Holger Brunck Date: Mon, 19 Dec 2011 09:07:47 +0100 Subject: [U-Boot] [PATCH] km/common: add toolchain variable In-Reply-To: <20111217204908.102C21ECC61@gemini.denx.de> References: <1323879110-8404-1-git-send-email-holger.brunck@keymile.com> <20111217204908.102C21ECC61@gemini.denx.de> Message-ID: <4EEEF0D3.5040302@keymile.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Wolfgang, On 12/17/2011 09:49 PM, Wolfgang Denk wrote: > In message <1323879110-8404-1-git-send-email-holger.brunck@keymile.com> you wrote: >> Add a variable "toolchain" and configure the rootpath >> for the nfsargs with this variable. >> >> Signed-off-by: Holger Brunck >> cc: Wolfgang Denk >> --- >> board/keymile/scripts/README | 2 +- >> board/keymile/scripts/develop-common.txt | 3 ++- >> 2 files changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/board/keymile/scripts/README b/board/keymile/scripts/README >> index 7fbcf74..dd935b2 100644 >> --- a/board/keymile/scripts/README >> +++ b/board/keymile/scripts/README >> @@ -7,7 +7,7 @@ default environment must be parsed: >> run develop : setup environment to configure for rootfs via nfs >> run ramfs : setup environment to configure for rootfs in ram >> >> -Last change: 20.05.2011 >> +Last change: 24.11.2011 > > Does this really make any sense? Which date are you recording here/ > When you (think) you last edited the file? When you applied the patch > to your local tree? When you submitted it for mainline? When it > actually got applied? > What I want to record is to track the version of the scripts and this makes sense for me. In the end the scripts are copied into /tftpboot on each developers machine and is therefore not under git control. It is an easy indication wether the scripts are uptodate or not, without starting a diff tool and compare them with the latest git tree. Inside the git tree the information is useless, I agree. > I recommend to get rid of this, and rather use git revision > information instead. > I would like to keep this, because git does not easily help here. Best regards Holger