From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: Tidy up of PRAM init to use getenv_f()
Date: Mon, 19 Dec 2011 11:09:30 +0100 [thread overview]
Message-ID: <4EEF0D5A.2030001@aribaud.net> (raw)
In-Reply-To: <1318278244-3613-1-git-send-email-sjg@chromium.org>
Hi Simon,
Le 10/10/2011 22:24, Simon Glass a ?crit :
> It seems that few people use CONFIG_PRAM on ARM. The getenv_r() function has
> been renamed to getenv_f().
Please correct the commit message: it does not rename the function, it
switches from callong the _r version to calling the _f version.
> Signed-off-by: Simon Glass<sjg@chromium.org>
> ---
> arch/arm/lib/board.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
> index 1fe3751..653345f 100644
> --- a/arch/arm/lib/board.c
> +++ b/arch/arm/lib/board.c
> @@ -317,7 +317,7 @@ void board_init_f(ulong bootflag)
> /*
> * reserve protected RAM
> */
> - i = getenv_r("pram", (char *)tmp, sizeof(tmp));
> + i = getenv_f("pram", (char *)tmp, sizeof(tmp));
> reg = (i> 0) ? simple_strtoul((const char *)tmp, NULL, 10) :
> CONFIG_PRAM;
> addr -= (reg<< 10); /* size is in kB */
Amicalement,
--
Albert.
next prev parent reply other threads:[~2011-12-19 10:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 20:24 [U-Boot] [PATCH] arm: Tidy up of PRAM init to use getenv_f() Simon Glass
2011-12-19 10:09 ` Albert ARIBAUD [this message]
2011-12-22 6:05 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEF0D5A.2030001@aribaud.net \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox