* [U-Boot] [PATCH] arm: Tidy up of PRAM init to use getenv_f()
@ 2011-10-10 20:24 Simon Glass
2011-12-19 10:09 ` Albert ARIBAUD
0 siblings, 1 reply; 3+ messages in thread
From: Simon Glass @ 2011-10-10 20:24 UTC (permalink / raw)
To: u-boot
It seems that few people use CONFIG_PRAM on ARM. The getenv_r() function has
been renamed to getenv_f().
Signed-off-by: Simon Glass <sjg@chromium.org>
---
arch/arm/lib/board.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
index 1fe3751..653345f 100644
--- a/arch/arm/lib/board.c
+++ b/arch/arm/lib/board.c
@@ -317,7 +317,7 @@ void board_init_f(ulong bootflag)
/*
* reserve protected RAM
*/
- i = getenv_r("pram", (char *)tmp, sizeof(tmp));
+ i = getenv_f("pram", (char *)tmp, sizeof(tmp));
reg = (i > 0) ? simple_strtoul((const char *)tmp, NULL, 10) :
CONFIG_PRAM;
addr -= (reg << 10); /* size is in kB */
--
1.7.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [U-Boot] [PATCH] arm: Tidy up of PRAM init to use getenv_f()
2011-10-10 20:24 [U-Boot] [PATCH] arm: Tidy up of PRAM init to use getenv_f() Simon Glass
@ 2011-12-19 10:09 ` Albert ARIBAUD
2011-12-22 6:05 ` Simon Glass
0 siblings, 1 reply; 3+ messages in thread
From: Albert ARIBAUD @ 2011-12-19 10:09 UTC (permalink / raw)
To: u-boot
Hi Simon,
Le 10/10/2011 22:24, Simon Glass a ?crit :
> It seems that few people use CONFIG_PRAM on ARM. The getenv_r() function has
> been renamed to getenv_f().
Please correct the commit message: it does not rename the function, it
switches from callong the _r version to calling the _f version.
> Signed-off-by: Simon Glass<sjg@chromium.org>
> ---
> arch/arm/lib/board.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
> index 1fe3751..653345f 100644
> --- a/arch/arm/lib/board.c
> +++ b/arch/arm/lib/board.c
> @@ -317,7 +317,7 @@ void board_init_f(ulong bootflag)
> /*
> * reserve protected RAM
> */
> - i = getenv_r("pram", (char *)tmp, sizeof(tmp));
> + i = getenv_f("pram", (char *)tmp, sizeof(tmp));
> reg = (i> 0) ? simple_strtoul((const char *)tmp, NULL, 10) :
> CONFIG_PRAM;
> addr -= (reg<< 10); /* size is in kB */
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 3+ messages in thread* [U-Boot] [PATCH] arm: Tidy up of PRAM init to use getenv_f()
2011-12-19 10:09 ` Albert ARIBAUD
@ 2011-12-22 6:05 ` Simon Glass
0 siblings, 0 replies; 3+ messages in thread
From: Simon Glass @ 2011-12-22 6:05 UTC (permalink / raw)
To: u-boot
Hi Albert,
On Mon, Dec 19, 2011 at 2:09 AM, Albert ARIBAUD
<albert.u.boot@aribaud.net> wrote:
> Hi Simon,
>
> Le 10/10/2011 22:24, Simon Glass a ?crit :
>
>> It seems that few people use CONFIG_PRAM on ARM. The getenv_r() function
>> has
>> been renamed to getenv_f().
>
>
> Please correct the commit message: it does not rename the function, it
> switches from callong the _r version to calling the _f version.
Please drop this patch, as it still doesn't allow PRAM to actually work on ARM.
Regards,
Simon
>
>
>> Signed-off-by: Simon Glass<sjg@chromium.org>
>> ---
>> ?arch/arm/lib/board.c | ? ?2 +-
>> ?1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
>> index 1fe3751..653345f 100644
>> --- a/arch/arm/lib/board.c
>> +++ b/arch/arm/lib/board.c
>> @@ -317,7 +317,7 @@ void board_init_f(ulong bootflag)
>> ? ? ? ?/*
>> ? ? ? ? * reserve protected RAM
>> ? ? ? ? */
>> - ? ? ? i = getenv_r("pram", (char *)tmp, sizeof(tmp));
>> + ? ? ? i = getenv_f("pram", (char *)tmp, sizeof(tmp));
>> ? ? ? ?reg = (i> ?0) ? simple_strtoul((const char *)tmp, NULL, 10) :
>> ? ? ? ? ? ? ? ?CONFIG_PRAM;
>> ? ? ? ?addr -= (reg<< ?10); ? ? ? ? ? ?/* size is in kB */
>
>
> Amicalement,
> --
> Albert.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-12-22 6:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-10 20:24 [U-Boot] [PATCH] arm: Tidy up of PRAM init to use getenv_f() Simon Glass
2011-12-19 10:09 ` Albert ARIBAUD
2011-12-22 6:05 ` Simon Glass
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox