From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Tue, 20 Dec 2011 07:55:43 +0100 Subject: [U-Boot] [PATCH] arm: Tegra: Fix Harmony and Ventana builds In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF176BE92C09@HQMAIL01.nvidia.com> References: <1324336129-4488-1-git-send-email-twarren@nvidia.com> <74CDBE0F657A3D45AFBB94109FB122FF176BE92C09@HQMAIL01.nvidia.com> Message-ID: <4EF0316F.1080100@aribaud.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi all, Le 20/12/2011 01:06, Stephen Warren a ?crit : > Tom Warren wrote at Monday, December 19, 2011 4:09 PM: >> Signed-off-by: Tom Warren >> >> BUG=none >> TEST=built all 3 (Harmony, Seaboard and Ventana) and tested Seaboard > > Tom, > > I'm a little confused by this. The patch removes ../common/board.o from > COBJS for Harmony and Ventana, but not from Seaboard, and at least in > u-boot-tegra/ next, Seaboard still references that file. > > Also, applying this patch causes Harmony and Ventana to fail to build > (link) due to undefined symbols typically provided by common/board.o. > > What branch is the patch targeted at, and what build problems is it > solving? Plus, I would suggest making the commit message less cryptic; I can make no heads or tails of these "BUG=" and "TEST=" lines. Amicalement, -- Albert.