From: Veli-Pekka Peltola <veli-pekka.peltola@bluegiga.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v6 1/4] mx28: Let imx_get_mac_from_fuse be common for mx28
Date: Tue, 20 Dec 2011 16:43:13 +0200 [thread overview]
Message-ID: <4EF09F01.3080308@bluegiga.com> (raw)
In-Reply-To: <201112201455.36738.marek.vasut@gmail.com>
On 12/20/2011 03:55 PM, Marek Vasut wrote:
>> Let imx_get_mac_from_fuse function be a common function, so that other
>> mx28 boards can reuse it.
[snip]
>> +static void __set_mac_vendor(char *mac)
[snip]
> It's good, but why not make it completely generic -- like mx28_adjust_mac() --
> so the users can for example change the last bit of the mac depending on the NIC
> that's used (FEC0 or FEC1). I think I proposed that. It's only a matter of
> adding a parameter (nic #) and renaming it :)
What is stored in MX28EVK CUST1 fuse? It seems to be CUST0 increased by
one. So maybe we should read it from there for FEC1?
It would be nice to have very generic fuse reading function that could
be used to read a serial number or similar user data. I will work this
out if you don't like to do it. I'm quite busy now so it might take a
week or two.
--
Veli-Pekka Peltola
next prev parent reply other threads:[~2011-12-20 14:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 13:53 [U-Boot] [PATCH v6 1/4] mx28: Let imx_get_mac_from_fuse be common for mx28 Fabio Estevam
2011-12-20 13:53 ` [U-Boot] [PATCH v6 2/4] mx28: Allow to set MAC address for the two FECs Fabio Estevam
2011-12-20 13:57 ` Marek Vasut
2011-12-20 14:39 ` Stefano Babic
2011-12-20 13:53 ` [U-Boot] [PATCH v6 3/4] mx28: Let dram_init be common for mx28 Fabio Estevam
2011-12-20 13:57 ` Marek Vasut
2011-12-20 13:53 ` [U-Boot] [PATCH v6 4/4] mx28evk: Add initial support for MX28EVK board Fabio Estevam
2011-12-20 13:58 ` Marek Vasut
2011-12-28 12:20 ` Fabio Estevam
2011-12-28 12:36 ` Stefano Babic
2011-12-28 12:46 ` Fabio Estevam
2011-12-28 13:04 ` Fabio Estevam
2011-12-28 13:12 ` Stefano Babic
2011-12-28 12:37 ` Stefano Babic
2011-12-20 13:55 ` [U-Boot] [PATCH v6 1/4] mx28: Let imx_get_mac_from_fuse be common for mx28 Marek Vasut
2011-12-20 14:43 ` Veli-Pekka Peltola [this message]
2011-12-20 14:45 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF09F01.3080308@bluegiga.com \
--to=veli-pekka.peltola@bluegiga.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox