From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rob Herring <robherring2@gmail.com>
Date: Tue, 20 Dec 2011 17:12:59 -0600
Subject: [U-Boot] [PATCH v3 1/2] net: add Calxeda xgmac driver
In-Reply-To: <20111220230923.A06F2822DA@gemini.denx.de>
References: <1322857309-2662-1-git-send-email-robherring2@gmail.com>
	<1323983750-3399-1-git-send-email-robherring2@gmail.com>
	<20111220224217.BFEBD19E5E2D@gemini.denx.de>
	<4EF11209.5050102@gmail.com>
	<20111220230923.A06F2822DA@gemini.denx.de>
Message-ID: <4EF1167B.1070001@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Wolfgang,

On 12/20/2011 05:09 PM, Wolfgang Denk wrote:
> Dear Rob Herring,
> 
> In message <4EF11209.5050102@gmail.com> you wrote:
>>
>>> Are there going to be any users for this driver?
>>
>> Yes. Patch 2/2 adds support to Calxeda Highbank.
> 
> I saw this myself 5 seconds later, but my "send" button has no "undo"
> function ;-)  Sorry...
> 
>>> Checkpatch says:
>>>
>>> WARNING: __aligned(size) is preferred over __attribute__((aligned(size)))
>>> #461: FILE: drivers/net/calxedaxgmac.c:317:
>>> +} __attribute__((aligned(32)));
>>>
>>> Is there any special reason not to change this?
>>
>> I thought it was a false positive because I didn't find any other users
>> of __aligned().
> 
> I think we should change this.  [I can do this when applying, if you
> like.]
> 

Agreed. If you're applying, I like. :)

Thanks,
Rob