From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] USB: add CONFIG_USB_INIT to autoinitialize USB before main_loop
Date: Thu, 22 Dec 2011 10:17:06 +0200 [thread overview]
Message-ID: <4EF2E782.8050503@compulab.co.il> (raw)
In-Reply-To: <20111222080653.9968311CDEB1@gemini.denx.de>
Hi Wolfgang,
On 12/22/11 10:06, Wolfgang Denk wrote:
> Dear Allen Martin,
>
> In message <1324515956-1642-1-git-send-email-amartin@nvidia.com> you wrote:
>> This allows systems to pause autoboot with USB keyboard. Tested on
>> tegra2 seaboard.
>>
>> Signed-off-by: Allen Martin <amartin@nvidia.com>
>> ---
>> README | 5 +++++
>> arch/arm/lib/board.c | 9 +++++++++
>> 2 files changed, 14 insertions(+), 0 deletions(-)
>
> This modification is in no way ARM specific, so if we accept it, it
> must be applied to all supported architectures.
>
> Where exacly is this feature nneded? You don;t enable it in any of
> the board configurations...
>
> Also, should we then not auto-enable this if CONFIG_USB_KEYBOARD is
> set?
Right, IMHO, there is no need for a new config option -
just make the USB init depend on CONFIG_USB_KEYBOARD.
--
Regards,
Igor.
next prev parent reply other threads:[~2011-12-22 8:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 1:05 [U-Boot] [PATCH] USB: add CONFIG_USB_INIT to autoinitialize USB before main_loop Allen Martin
2011-12-22 4:04 ` Marek Vasut
2011-12-22 18:54 ` Allen Martin
2011-12-22 19:10 ` Moffett, Kyle D
2011-12-22 19:27 ` Marek Vasut
2011-12-22 20:32 ` Allen Martin
2011-12-22 22:40 ` Allen Martin
2011-12-22 23:00 ` Wolfgang Denk
2011-12-22 8:06 ` Wolfgang Denk
2011-12-22 8:17 ` Igor Grinberg [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-12-22 22:25 Allen Martin
2011-12-23 0:52 Allen Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF2E782.8050503@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox