From mboxrd@z Thu Jan  1 00:00:00 1970
From: Igor Grinberg <grinberg@compulab.co.il>
Date: Thu, 22 Dec 2011 10:17:06 +0200
Subject: [U-Boot] [PATCH] USB: add CONFIG_USB_INIT to autoinitialize USB
 before main_loop
In-Reply-To: <20111222080653.9968311CDEB1@gemini.denx.de>
References: <1324515956-1642-1-git-send-email-amartin@nvidia.com>
	<20111222080653.9968311CDEB1@gemini.denx.de>
Message-ID: <4EF2E782.8050503@compulab.co.il>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Wolfgang,

On 12/22/11 10:06, Wolfgang Denk wrote:
> Dear Allen Martin,
> 
> In message <1324515956-1642-1-git-send-email-amartin@nvidia.com> you wrote:
>> This allows systems to pause autoboot with USB keyboard.  Tested on
>> tegra2 seaboard.
>>
>> Signed-off-by: Allen Martin <amartin@nvidia.com>
>> ---
>>  README               |    5 +++++
>>  arch/arm/lib/board.c |    9 +++++++++
>>  2 files changed, 14 insertions(+), 0 deletions(-)
> 
> This modification is in no way ARM specific, so if we accept it, it
> must be applied to all supported architectures.
> 
> Where exacly is this feature nneded?  You don;t enable it in any of
> the board configurations...
> 
> Also, should we then not auto-enable this if CONFIG_USB_KEYBOARD is
> set?

Right, IMHO, there is no need for a new config option -
just make the USB init depend on CONFIG_USB_KEYBOARD.


-- 
Regards,
Igor.