public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Horst Kronstorfer <u-boot@aon.at>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tools/mkenvimage.c: Fix a merge issue
Date: Sat, 24 Dec 2011 19:41:04 +0100	[thread overview]
Message-ID: <4EF61CC0.7070102@aon.at> (raw)
In-Reply-To: <20111224145753.BD5121EA134@gemini.denx.de>

On 12/24/2011 03:57 PM, Wolfgang Denk wrote:
> Dear Horst Kronstorfer,
>
> In message<1324723318-32752-1-git-send-email-hkronsto@frequentis.com>  you wrote:
>> With bfcc40bb09b05c90cc3b1496abb270eb8aa72134 'optopt' was reverted.
>>
>> Signed-off-by: Horst Kronstorfer<hkronsto@frequentis.com>
>> ---
>>   tools/mkenvimage.c |    4 ++--
>>   1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/mkenvimage.c b/tools/mkenvimage.c
>> index c5ed373..8ee2bd0 100644
>> --- a/tools/mkenvimage.c
>> +++ b/tools/mkenvimage.c
>> @@ -122,11 +122,11 @@ int main(int argc, char **argv)
>>   			return EXIT_SUCCESS;
>>   		case ':':
>>   			fprintf(stderr, "Missing argument for option -%c\n",
>> -				option);
>> +				optopt);
>>   			usage(argv[0]);
>>   			return EXIT_FAILURE;
>>   		default:
>> -			fprintf(stderr, "Wrong option -%c\n", option);
>> +			fprintf(stderr, "Wrong option -%c\n", optopt);
>>   			usage(prg);
>>   			return EXIT_FAILURE;
>
> This change is definitely wrong, as "optopt" is nowhere declared nor
> used in tools/mkenvimage.c
>

'optopt' is declared in unistd.h ... see 'man 3 getopt.'

br
-h

>
> Best regards,
>
> Wolfgang Denk
>

  reply	other threads:[~2011-12-24 18:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-24 10:41 [U-Boot] [PATCH] tools/mkenvimage.c: Fix a merge issue Horst Kronstorfer
2011-12-24 14:57 ` Wolfgang Denk
2011-12-24 18:41   ` Horst Kronstorfer [this message]
2012-01-05 15:36 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EF61CC0.7070102@aon.at \
    --to=u-boot@aon.at \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox