* [U-Boot] [PATCH] tools/mkenvimage.c: Fix a merge issue
@ 2011-12-24 10:41 Horst Kronstorfer
2011-12-24 14:57 ` Wolfgang Denk
2012-01-05 15:36 ` Wolfgang Denk
0 siblings, 2 replies; 4+ messages in thread
From: Horst Kronstorfer @ 2011-12-24 10:41 UTC (permalink / raw)
To: u-boot
With bfcc40bb09b05c90cc3b1496abb270eb8aa72134 'optopt' was reverted.
Signed-off-by: Horst Kronstorfer <hkronsto@frequentis.com>
---
tools/mkenvimage.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/mkenvimage.c b/tools/mkenvimage.c
index c5ed373..8ee2bd0 100644
--- a/tools/mkenvimage.c
+++ b/tools/mkenvimage.c
@@ -122,11 +122,11 @@ int main(int argc, char **argv)
return EXIT_SUCCESS;
case ':':
fprintf(stderr, "Missing argument for option -%c\n",
- option);
+ optopt);
usage(argv[0]);
return EXIT_FAILURE;
default:
- fprintf(stderr, "Wrong option -%c\n", option);
+ fprintf(stderr, "Wrong option -%c\n", optopt);
usage(prg);
return EXIT_FAILURE;
}
--
1.7.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] tools/mkenvimage.c: Fix a merge issue
2011-12-24 10:41 [U-Boot] [PATCH] tools/mkenvimage.c: Fix a merge issue Horst Kronstorfer
@ 2011-12-24 14:57 ` Wolfgang Denk
2011-12-24 18:41 ` Horst Kronstorfer
2012-01-05 15:36 ` Wolfgang Denk
1 sibling, 1 reply; 4+ messages in thread
From: Wolfgang Denk @ 2011-12-24 14:57 UTC (permalink / raw)
To: u-boot
Dear Horst Kronstorfer,
In message <1324723318-32752-1-git-send-email-hkronsto@frequentis.com> you wrote:
> With bfcc40bb09b05c90cc3b1496abb270eb8aa72134 'optopt' was reverted.
>
> Signed-off-by: Horst Kronstorfer <hkronsto@frequentis.com>
> ---
> tools/mkenvimage.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/mkenvimage.c b/tools/mkenvimage.c
> index c5ed373..8ee2bd0 100644
> --- a/tools/mkenvimage.c
> +++ b/tools/mkenvimage.c
> @@ -122,11 +122,11 @@ int main(int argc, char **argv)
> return EXIT_SUCCESS;
> case ':':
> fprintf(stderr, "Missing argument for option -%c\n",
> - option);
> + optopt);
> usage(argv[0]);
> return EXIT_FAILURE;
> default:
> - fprintf(stderr, "Wrong option -%c\n", option);
> + fprintf(stderr, "Wrong option -%c\n", optopt);
> usage(prg);
> return EXIT_FAILURE;
This change is definitely wrong, as "optopt" is nowhere declared nor
used in tools/mkenvimage.c
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The game of life is a game of boomerangs. Our thoughts, deeds and
words return to us sooner or later with astounding accuracy.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] tools/mkenvimage.c: Fix a merge issue
2011-12-24 14:57 ` Wolfgang Denk
@ 2011-12-24 18:41 ` Horst Kronstorfer
0 siblings, 0 replies; 4+ messages in thread
From: Horst Kronstorfer @ 2011-12-24 18:41 UTC (permalink / raw)
To: u-boot
On 12/24/2011 03:57 PM, Wolfgang Denk wrote:
> Dear Horst Kronstorfer,
>
> In message<1324723318-32752-1-git-send-email-hkronsto@frequentis.com> you wrote:
>> With bfcc40bb09b05c90cc3b1496abb270eb8aa72134 'optopt' was reverted.
>>
>> Signed-off-by: Horst Kronstorfer<hkronsto@frequentis.com>
>> ---
>> tools/mkenvimage.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/mkenvimage.c b/tools/mkenvimage.c
>> index c5ed373..8ee2bd0 100644
>> --- a/tools/mkenvimage.c
>> +++ b/tools/mkenvimage.c
>> @@ -122,11 +122,11 @@ int main(int argc, char **argv)
>> return EXIT_SUCCESS;
>> case ':':
>> fprintf(stderr, "Missing argument for option -%c\n",
>> - option);
>> + optopt);
>> usage(argv[0]);
>> return EXIT_FAILURE;
>> default:
>> - fprintf(stderr, "Wrong option -%c\n", option);
>> + fprintf(stderr, "Wrong option -%c\n", optopt);
>> usage(prg);
>> return EXIT_FAILURE;
>
> This change is definitely wrong, as "optopt" is nowhere declared nor
> used in tools/mkenvimage.c
>
'optopt' is declared in unistd.h ... see 'man 3 getopt.'
br
-h
>
> Best regards,
>
> Wolfgang Denk
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] tools/mkenvimage.c: Fix a merge issue
2011-12-24 10:41 [U-Boot] [PATCH] tools/mkenvimage.c: Fix a merge issue Horst Kronstorfer
2011-12-24 14:57 ` Wolfgang Denk
@ 2012-01-05 15:36 ` Wolfgang Denk
1 sibling, 0 replies; 4+ messages in thread
From: Wolfgang Denk @ 2012-01-05 15:36 UTC (permalink / raw)
To: u-boot
Dear Horst Kronstorfer,
In message <1324723318-32752-1-git-send-email-hkronsto@frequentis.com> you wrote:
> With bfcc40bb09b05c90cc3b1496abb270eb8aa72134 'optopt' was reverted.
>
> Signed-off-by: Horst Kronstorfer <hkronsto@frequentis.com>
> ---
> tools/mkenvimage.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The net result is a system that is not only binary compatible with
4.3 BSD, but is even bug for bug compatible in almost all features."
- Avadit Tevanian, Jr., "Architecture-Independent Virtual Memory
Management for Parallel and Distributed Environments: The Mach
Approach"
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-05 15:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-24 10:41 [U-Boot] [PATCH] tools/mkenvimage.c: Fix a merge issue Horst Kronstorfer
2011-12-24 14:57 ` Wolfgang Denk
2011-12-24 18:41 ` Horst Kronstorfer
2012-01-05 15:36 ` Wolfgang Denk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox