[U-Boot] U-boot doesn't work on OMAP4430 ES2.0

[U-Boot] U-boot doesn't work on OMAP4430 ES2.0

[Raúl Porcel]

Hi,

Following with the issue on
http://comments.gmane.org/gmane.comp.boot-loaders.u-boot/111922

Looks like the 23e9f0723e48615332119de4f4ec7a833a282628 commit was
supposed to fix this, but it doesn't, the problem is still present.

Steve Sakoman's git tree has a different patch:
http://www.sakoman.com/cgi-bin/gitweb.cgi?p=u-boot.git;a=commitdiff;h=edb614543dbd007f5b9873e022b8f5aaefe65ba5;hp=1ffe0d2865184336d9e7176dbaf8bb4781f8719a

Indeed applying the patch in his tree makes it work. After talking with
him he guessed that maybe the fix was supposed to touch efuse_2 and not
efuse_1 like in the original patch.

Thanks

[U-Boot] U-boot doesn't work on OMAP4430 ES2.0

[Marek Vasut]

> Hi,
> 
> Following with the issue on
> http://comments.gmane.org/gmane.comp.boot-loaders.u-boot/111922
> 
> Looks like the 23e9f0723e48615332119de4f4ec7a833a282628 commit was
> supposed to fix this, but it doesn't, the problem is still present.
> 
> Steve Sakoman's git tree has a different patch:
> http://www.sakoman.com/cgi-bin/gitweb.cgi?p=u-boot.git;a=commitdiff;h=edb61
> 4543dbd007f5b9873e022b8f5aaefe65ba5;hp=1ffe0d2865184336d9e7176dbaf8bb4781f8
> 719a
> 
> Indeed applying the patch in his tree makes it work. After talking with
> him he guessed that maybe the fix was supposed to touch efuse_2 and not
> efuse_1 like in the original patch.
> 
> Thanks

Please Cc the omap custodian with this. Also, if you have a patch, please submit 
it too.

M

[U-Boot] U-boot doesn't work on OMAP4430 ES2.0

[Tom Rini]

On Mon, Dec 26, 2011 at 4:06 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
>> Hi,
>>
>> Following with the issue on
>> http://comments.gmane.org/gmane.comp.boot-loaders.u-boot/111922
>>
>> Looks like the 23e9f0723e48615332119de4f4ec7a833a282628 commit was
>> supposed to fix this, but it doesn't, the problem is still present.
>>
>> Steve Sakoman's git tree has a different patch:
>> http://www.sakoman.com/cgi-bin/gitweb.cgi?p=u-boot.git;a=commitdiff;h=edb61
>> 4543dbd007f5b9873e022b8f5aaefe65ba5;hp=1ffe0d2865184336d9e7176dbaf8bb4781f8
>> 719a
>>
>> Indeed applying the patch in his tree makes it work. After talking with
>> him he guessed that maybe the fix was supposed to touch efuse_2 and not
>> efuse_1 like in the original patch.
>>
>> Thanks
>
> Please Cc the omap custodian with this. Also, if you have a patch, please submit
> it too.

Note that I've seen this but I'm on vacation this week so I've seen
this.  Tested on a few boards patches greatly appreciated otherwise
I'll see what I can get going early next week (and I might have to
hunt up someone with ES2.0 silicon).  Thanks!

-- 
Tom

[U-Boot] U-boot doesn't work on OMAP4430 ES2.0

[Aneesh V]

Hi Raul,

On Monday 26 December 2011 11:38 PM, Ra?l Porcel wrote:
> Hi,
>
> Following with the issue on
> http://comments.gmane.org/gmane.comp.boot-loaders.u-boot/111922
>
> Looks like the 23e9f0723e48615332119de4f4ec7a833a282628 commit was
> supposed to fix this, but it doesn't, the problem is still present.
>
> Steve Sakoman's git tree has a different patch:
> http://www.sakoman.com/cgi-bin/gitweb.cgi?p=u-boot.git;a=commitdiff;h=edb614543dbd007f5b9873e022b8f5aaefe65ba5;hp=1ffe0d2865184336d9e7176dbaf8bb4781f8719a
>
> Indeed applying the patch in his tree makes it work. After talking with
> him he guessed that maybe the fix was supposed to touch efuse_2 and not
> efuse_1 like in the original patch.

Yes, this is a mix-up. I shall send a new patch. Will you be able to test
it for me. I don't have an ES2.0 Panda with me anymore. This issue is
not there on ES2.0 SDP.

regards,
Aneesh

[U-Boot] [PATCH] omap4: fix boot issue on ES2.0 Panda

[Aneesh V]

Fix boot issue on ES2.0 Panda by tuning some
IO settings. The CONTROL_EFUSE_2 register has
to be over-ridden in software for 4430 boards.

Commit 23e9f0723e48615332119de4f4ec7a833a282628
wrongly did this for CONTROL_EFUSE_1. Reverting
this and doing it for CONTROL_EFUSE_2.

Signed-off-by: Aneesh V <aneesh@ti.com>
---
 arch/arm/cpu/armv7/omap4/hwinit.c      |    4 ++--
 arch/arm/include/asm/arch-omap4/omap.h |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/cpu/armv7/omap4/hwinit.c b/arch/arm/cpu/armv7/omap4/hwinit.c
index 37a86b4..91f8320 100644
--- a/arch/arm/cpu/armv7/omap4/hwinit.c
+++ b/arch/arm/cpu/armv7/omap4/hwinit.c
@@ -110,10 +110,10 @@ void do_io_settings(void)
 	 *	i. unconditionally for all 4430
 	 *	ii. only if un-trimmed for 4460
 	 */
-	if ((omap4_rev < OMAP4460_ES1_0) || !readl(&ctrl->control_efuse_1))
+	if (!readl(&ctrl->control_efuse_1))
 		writel(CONTROL_EFUSE_1_OVERRIDE, &ctrl->control_efuse_1);
 
-	if (!readl(&ctrl->control_efuse_2))
+	if ((omap4_rev < OMAP4460_ES1_0) || !readl(&ctrl->control_efuse_2))
 		writel(CONTROL_EFUSE_2_OVERRIDE, &ctrl->control_efuse_2);
 }
 #endif
diff --git a/arch/arm/include/asm/arch-omap4/omap.h b/arch/arm/include/asm/arch-omap4/omap.h
index 4d8c89f..416c6de 100644
--- a/arch/arm/include/asm/arch-omap4/omap.h
+++ b/arch/arm/include/asm/arch-omap4/omap.h
@@ -116,7 +116,7 @@
 #define LDOSRAM_ACTMODE_VSET_IN_MASK	(0x1F << 5)
 #define LDOSRAM_VOLT_CTRL_OVERRIDE	0x0401040f
 #define CONTROL_EFUSE_1_OVERRIDE	0x1C4D0110
-#define CONTROL_EFUSE_2_OVERRIDE	0x00084000
+#define CONTROL_EFUSE_2_OVERRIDE	0x99084000
 
 /* LPDDR2 IO regs */
 #define CONTROL_LPDDR2IO_SLEW_125PS_DRV8_PULL_DOWN	0x1C1C1C1C
-- 
1.7.1

[U-Boot] U-boot doesn't work on OMAP4430 ES2.0

[Raúl Porcel]

Hi Aneesh

On 12/29/2011 07:31 PM, Aneesh V wrote:
> Hi Raul,
> 
> On Monday 26 December 2011 11:38 PM, Ra?l Porcel wrote:
>> Hi,
>>
>> Following with the issue on
>> http://comments.gmane.org/gmane.comp.boot-loaders.u-boot/111922
>>
>> Looks like the 23e9f0723e48615332119de4f4ec7a833a282628 commit was
>> supposed to fix this, but it doesn't, the problem is still present.
>>
>> Steve Sakoman's git tree has a different patch:
>> http://www.sakoman.com/cgi-bin/gitweb.cgi?p=u-boot.git;a=commitdiff;h=edb614543dbd007f5b9873e022b8f5aaefe65ba5;hp=1ffe0d2865184336d9e7176dbaf8bb4781f8719a
>>
>>
>> Indeed applying the patch in his tree makes it work. After talking with
>> him he guessed that maybe the fix was supposed to touch efuse_2 and not
>> efuse_1 like in the original patch.
> 
> Yes, this is a mix-up. I shall send a new patch. Will you be able to test
> it for me. I don't have an ES2.0 Panda with me anymore. This issue is
> not there on ES2.0 SDP.
> 
> regards,
> Aneesh

Sure, feel free to send a patch and i'll test it.

Thanks!

[U-Boot] [PATCH] omap4: fix boot issue on ES2.0 Panda

[asad]

On 12/29/2011 07:47 PM, Aneesh V wrote:
> Fix boot issue on ES2.0 Panda by tuning some
> IO settings. The CONTROL_EFUSE_2 register has
> to be over-ridden in software for 4430 boards.
> 
> Commit 23e9f0723e48615332119de4f4ec7a833a282628
> wrongly did this for CONTROL_EFUSE_1. Reverting
> this and doing it for CONTROL_EFUSE_2.
> 
> Signed-off-by: Aneesh V <aneesh@ti.com>
[snip]

Hi,

works fine:

U-Boot SPL 2011.12-00046-gbfcc40b-dirty (Dec 31 2011 - 12:14:09)
Texas Instruments OMAP4430 ES2.0
OMAP SD/MMC: 0
reading u-boot.img
reading u-boot.img


U-Boot 2011.12-00046-gbfcc40b-dirty (Dec 31 2011 - 12:14:09)

CPU  : OMAP4430 ES2.0
Board: OMAP4 Panda
I2C:   ready
DRAM:  1 GiB
MMC:   OMAP SD/MMC: 0
Using default environment

Thanks!

Tested-by: Ra?l Porcel <armin76@gentoo.org>

[U-Boot] [PATCH] omap4: fix boot issue on ES2.0 Panda

[Raúl Porcel]

On 12/31/2011 01:27 PM, asad wrote:
[snip]

Jeez, obviously this is me...

Thanks and sorry

[U-Boot] [PATCH] omap4: fix boot issue on ES2.0 Panda

[Tom Rini]

On Sat, Dec 31, 2011 at 5:27 AM, asad <armin@example.net> wrote:
> On 12/29/2011 07:47 PM, Aneesh V wrote:
>> Fix boot issue on ES2.0 Panda by tuning some
>> IO settings. The CONTROL_EFUSE_2 register has
>> to be over-ridden in software for 4430 boards.
>>
>> Commit 23e9f0723e48615332119de4f4ec7a833a282628
>> wrongly did this for CONTROL_EFUSE_1. Reverting
>> this and doing it for CONTROL_EFUSE_2.
>>
>> Signed-off-by: Aneesh V <aneesh@ti.com>
> [snip]
>
> Hi,
>
> works fine:
>
> U-Boot SPL 2011.12-00046-gbfcc40b-dirty (Dec 31 2011 - 12:14:09)
> Texas Instruments OMAP4430 ES2.0
> OMAP SD/MMC: 0
> reading u-boot.img
> reading u-boot.img
>
>
> U-Boot 2011.12-00046-gbfcc40b-dirty (Dec 31 2011 - 12:14:09)
>
> CPU ?: OMAP4430 ES2.0
> Board: OMAP4 Panda
> I2C: ? ready
> DRAM: ?1 GiB
> MMC: ? OMAP SD/MMC: 0
> Using default environment
>
> Thanks!
>
> Tested-by: Ra?l Porcel <armin76@gentoo.org>

Applied to u-boot-ti/master, thanks!

-- 
Tom