From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] m28evk: Use GENERATED_GBL_DATA_SIZE
Date: Thu, 29 Dec 2011 16:47:20 +0100 [thread overview]
Message-ID: <4EFC8B88.1010105@denx.de> (raw)
In-Reply-To: <201112291622.28427.marek.vasut@gmail.com>
On 29/12/2011 16:22, Marek Vasut wrote:
>> Use GENERATED_GBL_DATA_SIZE for calculating CONFIG_SYS_INIT_SP_OFFSET.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Maybe I'd be better to consolidate the i.MX28 config to a common config file and
> have only board specific stuff in the board-specific configs, which would in
> turn include the file?
But this issue is not strictly related only to MX28. The same is for any
SOC in u-boot, and most of CONFIG_ are duplicated in the configuration
files for boards having the same SOC.
At the moment, we do this only for slightly different boards (imx27lite
and magnesium, for example) or for boards having the same SOM.
Agree we can rationalize better, but it should be discussed if we plan
to introduce some hierarchy in the configuration files - the board
configuration file can include a SOC configuration file, that can
include a ARCH configuration file....
Apart of that, I think it is not bad to merge this Fabio's patch - it
makes the board consistent with the other ones.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2011-12-29 15:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-29 13:35 [U-Boot] [PATCH] m28evk: Use GENERATED_GBL_DATA_SIZE Fabio Estevam
2011-12-29 15:22 ` Marek Vasut
2011-12-29 15:38 ` Fabio Estevam
2011-12-29 15:47 ` Stefano Babic [this message]
2011-12-29 18:22 ` Marek Vasut
2012-01-04 13:53 ` Stefano Babic
2012-04-02 4:17 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EFC8B88.1010105@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox