From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 2/3] ARM:AM33XX: Add mmc/sd support
Date: Tue, 03 Jan 2012 16:50:38 +0200 [thread overview]
Message-ID: <4F0315BE.4020000@compulab.co.il> (raw)
In-Reply-To: <4F030EFC.2030505@ti.com>
Hi Tom,
On 01/03/12 16:21, Tom Rini wrote:
> On 01/03/2012 01:00 AM, Igor Grinberg wrote:
>> Hi Chandan, Tom,
>>
>> On 01/03/12 08:42, Chandan Nath wrote:
>>> This patch add supports for mmc/sd driver on AM335X platform.
>>> PLL and pinmux configurations for mmc/sd are configured in this
>>> patch.
>>>
>>> Signed-off-by: Chandan Nath <chandan.nath@ti.com>
>>> Signed-off-by: Tom Rini <trini@ti.com>
> [snip]
>>> diff --git a/arch/arm/include/asm/arch-am33xx/mmc_host_def.h b/arch/arm/include/asm/arch-am33xx/mmc_host_def.h
>>> new file mode 100644
>>> index 0000000..e56c018
>>> --- /dev/null
>>> +++ b/arch/arm/include/asm/arch-am33xx/mmc_host_def.h
> [snip]
>> Ahh, I see... most of it is just a copy/paste of the same data in:
>> arch/arm/include/asm/arch-omap3/mmc_host_def.h
>
> And arch-omap4 and arch-omap5, except for the base locations. I've
> talked a little with Wolfgang about this and on my cleanup list is
> making then posting something to give us <plat/> for includes (name like
> the kernel, extra deep directory structure to create it, hopefully not).
While this sounds promising, but I don't think
this is the right thing to do...
The reason why I think so, is that you are one person with that
cleanup list, while many others work on the current code and
probably don't have that (or any other) cleanup list. So they just
add new code (in many cases copy/pasted) and you accept it while
pushing another task to your cleanup list?
Well, I don't care, you can keep doing it,
but that does not sound right... and the your cleanup list will
never get empty...
--
Regards,
Igor.
next prev parent reply other threads:[~2012-01-03 14:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-03 6:42 [U-Boot] [PATCH v3 0/3] Added SPL support Chandan Nath
2012-01-03 6:42 ` [U-Boot] [PATCH v3 1/3] ARM:AM33XX: Fix ddr and timer register offset Chandan Nath
2012-01-03 6:42 ` [U-Boot] [PATCH v3 2/3] ARM:AM33XX: Add mmc/sd support Chandan Nath
2012-01-03 8:00 ` Igor Grinberg
2012-01-03 14:21 ` Tom Rini
2012-01-03 14:50 ` Igor Grinberg [this message]
2012-01-03 15:01 ` Tom Rini
2012-01-03 6:42 ` [U-Boot] [PATCH v3 3/3] ARM:AM33XX: Add SPL support for AM335X EVM Chandan Nath
2012-01-03 8:14 ` Igor Grinberg
2012-01-03 8:18 ` Kumar
2012-01-03 8:34 ` Igor Grinberg
2012-01-03 9:03 ` Wolfgang Denk
2012-01-03 14:24 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0315BE.4020000@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox