From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Tue, 3 Jan 2012 08:01:58 -0700 Subject: [U-Boot] [PATCH v3 2/3] ARM:AM33XX: Add mmc/sd support In-Reply-To: <4F0315BE.4020000@compulab.co.il> References: <1325572976-25795-1-git-send-email-chandan.nath@ti.com> <1325572976-25795-3-git-send-email-chandan.nath@ti.com> <4F02B5A1.9020308@compulab.co.il> <4F030EFC.2030505@ti.com> <4F0315BE.4020000@compulab.co.il> Message-ID: <4F031866.4060509@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 01/03/2012 07:50 AM, Igor Grinberg wrote: > Hi Tom, > > On 01/03/12 16:21, Tom Rini wrote: >> On 01/03/2012 01:00 AM, Igor Grinberg wrote: >>> Hi Chandan, Tom, >>> >>> On 01/03/12 08:42, Chandan Nath wrote: >>>> This patch add supports for mmc/sd driver on AM335X platform. >>>> PLL and pinmux configurations for mmc/sd are configured in this >>>> patch. >>>> >>>> Signed-off-by: Chandan Nath >>>> Signed-off-by: Tom Rini >> [snip] >>>> diff --git a/arch/arm/include/asm/arch-am33xx/mmc_host_def.h b/arch/arm/include/asm/arch-am33xx/mmc_host_def.h >>>> new file mode 100644 >>>> index 0000000..e56c018 >>>> --- /dev/null >>>> +++ b/arch/arm/include/asm/arch-am33xx/mmc_host_def.h >> [snip] >>> Ahh, I see... most of it is just a copy/paste of the same data in: >>> arch/arm/include/asm/arch-omap3/mmc_host_def.h >> >> And arch-omap4 and arch-omap5, except for the base locations. I've >> talked a little with Wolfgang about this and on my cleanup list is >> making then posting something to give us for includes (name like >> the kernel, extra deep directory structure to create it, hopefully not). > > While this sounds promising, but I don't think > this is the right thing to do... > The reason why I think so, is that you are one person with that > cleanup list, while many others work on the current code and > probably don't have that (or any other) cleanup list. So they just > add new code (in many cases copy/pasted) and you accept it while > pushing another task to your cleanup list? > Well, I don't care, you can keep doing it, > but that does not sound right... and the your cleanup list will > never get empty... I will put my TODO list up soon, but in this case, there's not going to be another new 'arch' added that copy/pastes this file too soon. The flip side is that I know that Chandan has a lot of hard work in front of him to get the rest of the drivers for am33xx into submittable shape that I don't want to delay that for this. -- Tom