From: Graeme Russ <graeme.russ@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 10/17] x86: Allow cache before copy to RAM
Date: Wed, 04 Jan 2012 22:29:17 +1100 [thread overview]
Message-ID: <4F04380D.5000904@gmail.com> (raw)
In-Reply-To: <CAPnjgZ07xQyWzx3zvcXzBa=7F7CSeofxT8ybQQgViH6RJyzi3A@mail.gmail.com>
Hi Simon,
On 04/01/12 16:40, Simon Glass wrote:
> Hi Graeme,
>
> On Sun, Jan 1, 2012 at 8:09 PM, Graeme Russ <graeme.russ@gmail.com> wrote:
>>
>> Signed-off-by: Graeme Russ <graeme.russ@gmail.com>
>> ---
>> arch/x86/lib/board.c | 15 ++++++++++-----
>> 1 files changed, 10 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/x86/lib/board.c b/arch/x86/lib/board.c
>> index ffddfbe..52e27e1 100644
>> --- a/arch/x86/lib/board.c
>> +++ b/arch/x86/lib/board.c
>> @@ -131,16 +131,11 @@ init_fnc_t *init_sequence_f[] = {
>> console_init_f,
>> dram_init_f,
>> calculate_relocation_address,
>> - copy_uboot_to_ram,
>> - clear_bss,
>> - do_elf_reloc_fixups,
>>
>> NULL,
>> };
>>
>> init_fnc_t *init_sequence_r[] = {
>> - copy_gd_to_ram,
>> - init_cache,
>> cpu_init_r, /* basic cpu dependent setup */
>> board_early_init_r, /* basic board dependent setup */
>> dram_init, /* configure available RAM banks */
>> @@ -269,6 +264,16 @@ void board_init_f(ulong boot_flags)
>>
>> void board_init_f_r(void)
>> {
>> + if (copy_gd_to_ram() != 0)
>> + hang();
>> +
>> + if (init_cache() != 0)
>> + hang();
>> +
>> + copy_uboot_to_ram();
>> + clear_bss();
>> + do_elf_reloc_fixups();
>
> Can you not just put these in the init list above? Why do they need to
> move back into this functoin?
board_init_f_r() is the intermediate step when we are running from Flash,
but with the stack and global data in RAM. If these functions are put in
init_sequence_f() we cannot enable the CPU cache (as the stack and global
data would get trashed). We can't put them in init_sequence_r because these
are the functions that actually copy U-Boot to RAM (and hence must be done
before init_sequence_r)
Regards,
Graeme
next prev parent reply other threads:[~2012-01-04 11:29 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-02 4:09 [U-Boot] [PATCH 00/17] x86: Rework of board init code (plus support patches) Graeme Russ
2012-01-02 4:09 ` [U-Boot] [PATCH 01/17] x86: Import glibc memcpy implementation Graeme Russ
2012-01-04 5:18 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 " Graeme Russ
2012-01-04 19:59 ` [U-Boot] [PATCH v2 02/17] x86: Speed up copy-to-RAM and clear BSS operations Graeme Russ
2012-01-04 20:04 ` Graeme Russ
2012-01-12 4:45 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 03/17] x86: Remove GDR related magic numbers Graeme Russ
2012-01-07 22:05 ` Simon Glass
2012-01-12 4:46 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 04/17] x86: Rework Global Descriptor Table loading Graeme Russ
2012-01-12 4:47 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 05/17] x86: Simplify Flash-to-RAM code execution transition Graeme Russ
2012-01-12 4:48 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 06/17] x86: Rework relocation calculations Graeme Russ
2012-01-12 4:49 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 07/17] x86: Use fs for global data Graeme Russ
2012-01-12 4:51 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 08/17] x86: Set GD_FLG_RELOC after entering in-RAM copy of U-Boot Graeme Russ
2012-01-12 4:51 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 09/17] x86: Create weak init_cache() and default enable_caches() functions Graeme Russ
2012-01-12 4:55 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 10/17] x86: Allow cache before copy to RAM Graeme Russ
2012-01-12 4:56 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 11/17] x86: Tweak IDT and GDT for alignment and readability Graeme Russ
2012-01-12 5:00 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 12/17] CHECKPATCH: arch/x86/lib/* Graeme Russ
2012-01-12 5:01 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 13/17] x86: Move do_go_exec() out of board.c Graeme Russ
2012-01-12 5:01 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 14/17] x86: Move setup_pcat_compatibility() " Graeme Russ
2012-01-12 5:02 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 15/17] x86: Move relocation code " Graeme Russ
2012-01-07 22:15 ` Simon Glass
2012-01-08 9:04 ` Graeme Russ
2012-01-08 17:59 ` Simon Glass
2012-01-12 5:03 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 16/17] x86: Split init functions " Graeme Russ
2012-01-12 5:03 ` Simon Glass
2012-01-04 19:59 ` [U-Boot] [PATCH v2 17/17] x86: Convert board_init_f_r to a processing loop Graeme Russ
2012-01-07 22:21 ` Simon Glass
2012-01-08 9:10 ` Graeme Russ
2012-01-08 18:01 ` Simon Glass
2012-01-12 5:04 ` Simon Glass
2012-01-12 4:44 ` [U-Boot] [PATCH v2 01/17] x86: Import glibc memcpy implementation Simon Glass
2012-01-02 4:09 ` [U-Boot] [PATCH 02/17] x86: Speed up copy-to-RAM and clear BSS operations Graeme Russ
2012-01-04 5:21 ` Simon Glass
2012-01-04 10:04 ` Graeme Russ
2012-01-02 4:09 ` [U-Boot] [PATCH 03/17] x86: Remove GDR related magic numbers Graeme Russ
2012-01-04 5:23 ` Simon Glass
2012-01-04 10:20 ` Graeme Russ
2012-01-02 4:09 ` [U-Boot] [PATCH 04/17] x86: Rework Global Descriptor Table loading Graeme Russ
2012-01-04 5:24 ` Simon Glass
2012-01-04 10:30 ` Graeme Russ
2012-01-02 4:09 ` [U-Boot] [PATCH 05/17] x86: Simplify Flash-to-RAM code execution transition Graeme Russ
2012-01-04 5:28 ` Simon Glass
2012-01-04 10:59 ` Graeme Russ
2012-01-02 4:09 ` [U-Boot] [PATCH 06/17] x86: Rework relocation calcuations Graeme Russ
2012-01-04 5:30 ` Simon Glass
2012-01-02 4:09 ` [U-Boot] [PATCH 07/17] x86: Use fs for global data Graeme Russ
2012-01-04 5:36 ` Simon Glass
2012-01-04 11:14 ` Graeme Russ
2012-01-02 4:09 ` [U-Boot] [PATCH 08/17] x86: Set GD_FLG_RELOC after entering in-RAM copy of U-Boot Graeme Russ
2012-01-04 5:37 ` Simon Glass
2012-01-02 4:09 ` [U-Boot] [PATCH 09/17] x86: Create weak init_cache() function Graeme Russ
2012-01-04 5:38 ` Simon Glass
2012-01-04 11:25 ` Graeme Russ
2012-01-02 4:09 ` [U-Boot] [PATCH 10/17] x86: Allow cache before copy to RAM Graeme Russ
2012-01-04 5:40 ` Simon Glass
2012-01-04 11:29 ` Graeme Russ [this message]
2012-01-02 4:09 ` [U-Boot] [PATCH 11/17] CHECKPATCH: arch/x86/cpu/* Graeme Russ
2012-01-04 5:42 ` Simon Glass
2012-01-04 11:35 ` Graeme Russ
2012-01-02 4:09 ` [U-Boot] [PATCH 12/17] CHECKPATCH: arch/x86/lib/* Graeme Russ
2012-01-04 5:47 ` Simon Glass
2012-01-02 4:09 ` [U-Boot] [PATCH 13/17] x86: Move do_go_exec() out of board.c Graeme Russ
2012-01-04 5:48 ` Simon Glass
2012-01-02 4:09 ` [U-Boot] [PATCH 14/17] x86: Move setup_pcat_compatibility() " Graeme Russ
2012-01-04 5:48 ` Simon Glass
2012-01-04 11:38 ` Graeme Russ
2012-01-02 4:09 ` [U-Boot] [PATCH 15/17] x86: Move relocation code " Graeme Russ
2012-01-02 4:09 ` [U-Boot] [PATCH 16/17] x86: Simplify board.c Graeme Russ
2012-01-04 5:51 ` Simon Glass
2012-01-04 11:50 ` Graeme Russ
2012-01-02 4:09 ` [U-Boot] [PATCH 17/17] x86: Tweak initialisation procedure Graeme Russ
2012-01-04 5:52 ` Simon Glass
2012-01-04 12:02 ` Graeme Russ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F04380D.5000904@gmail.com \
--to=graeme.russ@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox