From mboxrd@z Thu Jan 1 00:00:00 1970 From: Graeme Russ Date: Wed, 04 Jan 2012 22:50:37 +1100 Subject: [U-Boot] [PATCH 16/17] x86: Simplify board.c In-Reply-To: References: <1325477374-6417-1-git-send-email-graeme.russ@gmail.com> <1325477374-6417-17-git-send-email-graeme.russ@gmail.com> Message-ID: <4F043D0D.3040609@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, On 04/01/12 16:51, Simon Glass wrote: > Hi Graeme, > > On Sun, Jan 1, 2012 at 8:09 PM, Graeme Russ wrote: >> >> Signed-off-by: Graeme Russ >> --- >> arch/x86/include/asm/init_helpers.h | 39 +++++ >> arch/x86/include/asm/init_wrappers.h | 42 +++++ >> arch/x86/lib/Makefile | 2 + >> arch/x86/lib/board.c | 297 +++++++++------------------------- >> arch/x86/lib/init_helpers.c | 142 ++++++++++++++++ >> arch/x86/lib/init_wrappers.c | 137 ++++++++++++++++ > > What is the rationale for putting these into separate files? If you > didn't then they would be static and presumably less code size. The rationale is to reduce board.c to a set of init function arrays, an init function execution loop and three initialisation phase (_f, _f_r, and _r) functions which should be a generic methodology for all architectures > Also for the commit message, is this really a simplification? It looks > more like you are splitting the code into separate functions. I'll change to title and commit message Regards, Graeme